fix: escape single quote when building error message for required property#716
Merged
mcollina merged 5 commits intofastify:masterfrom May 6, 2024
Merged
Conversation
Contributor
Author
|
@ivan-tymoshenko could you please try to restart the CI? Seems the fail is not related to the changes in this PR |
Member
|
Seems like there is an issue on node 14? This is the 4th run |
Member
|
Yes. macos-latest gha env is now arm based. There is no Node v14 for arm. It's failing everywhere. Either we test on older Mac envs or we just ignore that combo. |
Contributor
|
Lets ignore it. |
gurgunday
reviewed
Apr 30, 2024
Member
gurgunday
left a comment
There was a problem hiding this comment.
Just to make sure, can you please add another test for double quote as well:
const stringify = build({
type: 'object',
properties: {
'"': { type: 'string' }
},
required: [
'"'
]
})
gurgunday
approved these changes
May 6, 2024
Member
gurgunday
left a comment
There was a problem hiding this comment.
yeah lgtm, that regex seems necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #715
Checklist
npm run testandnpm run benchmarkand the Code of conduct