Strip external schemas from standalone compiled code#704
Merged
mcollina merged 1 commit intofastify:masterfrom May 21, 2024
Merged
Strip external schemas from standalone compiled code#704mcollina merged 1 commit intofastify:masterfrom
mcollina merged 1 commit intofastify:masterfrom
Conversation
Closed
2 tasks
Member
ivan-tymoshenko
left a comment
There was a problem hiding this comment.
I see that this is a serialized state, but can you check if validator still works after this change. You need to use oneOf/anyOf keywords in the external schemas to trigger the validator usage.
Contributor
Author
|
Thanks for the feedback. I will check the oneOf/anyOf use case. |
24f9e9c to
2c2afd8
Compare
2c2afd8 to
935ad9d
Compare
Contributor
Author
|
I can now confirm with a proper test case that it works with the oneOf case / validator case. |
ivan-tymoshenko
approved these changes
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct