BREAKING CHANGE: migrate to node test runner#58
Closed
ilteoood wants to merge 3 commits intofastify:masterfrom
Closed
BREAKING CHANGE: migrate to node test runner#58ilteoood wants to merge 3 commits intofastify:masterfrom
ilteoood wants to merge 3 commits intofastify:masterfrom
Conversation
Contributor
|
The library is still compatible with older node versions, but because we migrate to node native runner, it will not be testable with node 16 and 18, and as such we can not guarantee that it still work in those versions. |
Member
|
I would a actually keep this tested with tape. It's a tiny utility that can support many old node versions without duplications or being tied to Node.js. |
Contributor
Author
|
Whatever you prefer guys is fine for me |
Member
|
Thanks for being cool about it @ilteoood, and thanks for your contributions so far! |
Member
|
Thanks @ilteoood! |
Contributor
|
Yes, thank you for being understanding. We hope we still see contributions by you ;) |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct