Skip to content

BREAKING CHANGE: migrate to node test runner#58

Closed
ilteoood wants to merge 3 commits intofastify:masterfrom
ilteoood:master
Closed

BREAKING CHANGE: migrate to node test runner#58
ilteoood wants to merge 3 commits intofastify:masterfrom
ilteoood:master

Conversation

@ilteoood
Copy link

@ilteoood ilteoood commented Jan 7, 2025

Checklist

@ilteoood ilteoood changed the title chore: migrate to node test runner BREAKING CHANGE: migrate to node test runner Jan 7, 2025
@Uzlopak
Copy link
Contributor

Uzlopak commented Jan 8, 2025

The library is still compatible with older node versions, but because we migrate to node native runner, it will not be testable with node 16 and 18, and as such we can not guarantee that it still work in those versions.

@mcollina
Copy link
Member

mcollina commented Jan 8, 2025

I would a actually keep this tested with tape. It's a tiny utility that can support many old node versions without duplications or being tied to Node.js.

@Uzlopak
Copy link
Contributor

Uzlopak commented Jan 8, 2025

@ilteoood

I created #59 which superseeds this PR. I also think, that we should keep tape in this case, even though it is slow and super heavy, but it ensures the backwards compatibility.

@ilteoood
Copy link
Author

ilteoood commented Jan 8, 2025

Whatever you prefer guys is fine for me

@Fdawgs
Copy link
Member

Fdawgs commented Jan 8, 2025

Thanks for being cool about it @ilteoood, and thanks for your contributions so far!

@mcollina
Copy link
Member

mcollina commented Jan 8, 2025

Thanks @ilteoood!

@mcollina mcollina closed this Jan 8, 2025
@Uzlopak
Copy link
Contributor

Uzlopak commented Jan 8, 2025

Yes, thank you for being understanding. We hope we still see contributions by you ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants