Conversation
Contributor
|
Maybe we can create something generic for the fastify org workflows based on this? https://github.com/nodejs/readable-stream/blob/main/.github/workflows/browsers.yml |
Member
Author
That is huge:
I must say that I can't invest time on this task
|
Member
Author
|
This PR solves:
I would add/discuss full browser support in a separate issue - as currently, the README does not mention it |
Uzlopak
reviewed
Nov 27, 2022
| @@ -24,6 +24,7 @@ | |||
| "devDependencies": { | |||
| "standard": "^17.0.0", | |||
| "tap": "^16.3.0", | |||
Member
Author
There was a problem hiding this comment.
Yes, we can. i keept it as test runner: it reads the tap output by tape and checks the coverage. I thought it is a a "standard" across the org and a friendly output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up #13