Skip to content

Conversation

@Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Aug 30, 2022

eslint-plugin-node is no longer maintained.
Main repo migrated a while back:

https://github.com/fastify/fastify/blob/67bee117a7c5c6dad503f656204e49cf329a37af/package.json#L144

Checklist

@Fdawgs Fdawgs requested a review from Uzlopak August 30, 2022 12:36
@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 30, 2022

Does it work without touching the eslint config?

@Fdawgs
Copy link
Member Author

Fdawgs commented Aug 30, 2022

Does it work without touching the eslint config?

Ah fudge, missed that.

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 30, 2022

I am just curios why it is not erroring when linting. Maybe the plugin gets not required at all?

@climba03003
Copy link
Member

Maybe the plugin gets not required at all?

ESLint always try his best to lint even if their are something wrong with the setting.

Replace to eslint-plugin-n require the bump all the corresponding packages which includes eslint and eslint-config-standard.
They are not independent from each another.

@Fdawgs
Copy link
Member Author

Fdawgs commented Sep 2, 2022

Does it work without touching the eslint config?

Sorted in 603b708

@Uzlopak Uzlopak merged commit 2a57180 into master Sep 2, 2022
@Uzlopak Uzlopak deleted the Fdawgs-patch-1 branch September 2, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants