fix: lower lookbehind size to needleLength - 1 #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Bench (node 22): master: gurgunday@DELL-G15:~/work/OSS/busboy/benchmarks$ npm run benchmark-fastify
> busboy-benchmarks@1.0.0 benchmark-fastify
> node busboy/executioner.js -c 1
Mean time for fastify-busboy is 177610.58582281295 nanoseconds
all donepr: gurgunday@DELL-G15:~/work/OSS/busboy/benchmarks$ npm run benchmark-fastify
> busboy-benchmarks@1.0.0 benchmark-fastify
> node busboy/executioner.js -c 1
Mean time for fastify-busboy is 174747.183856004 nanoseconds
all done |
zekth
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lookbehind size doesn't need to be the same size as the needle, the last index is never used
Here's why: if it reaches the needle size with an incoming buffer, we immediately check and empty it anyway, we never store data that has enough length to be compared to the needle, it always has to be at max 1 less, otherwise the check would happen -- it's one of the guarantees of the algorithm
The test changes break nothing, we just had to change lookbehind length in expected checks