Conversation
- process can be "running" after ReadAllData is called if aborted, in which case cleanup happens in WaitForExit - removing assert here makes process handling consistent with other invocations
…builds [Note] Failed/aborted multi-target builds will now behave the same as single target builds, stopping as soon as possible. -nostoponerror can be used to build as much as possible instead, as was already the case for single target builds. [Improvement] Build stop on failure/abort behavior for multiple targets matches one target builds [Improvement] Build output now differentiates "Failure" from "Incomplete" for multiple targets
- ensure tests reliably check desired behaviors - make remaining work to enable some tests for OSX/Linux more explicit
- the test and the processes we create try to coordinate with the same mutex - the launched executable now handles the test acquiring the mutex before it has started which would occur under heavy load - there are still some issue with this test: -- build can finish as "Incomplete" depending on timing) but this needs deeper fixes to build cancellation to fix -- test is Windows only
- fix implcit conversion of NODE_RESULT_FAILED to boolean false
- remove NODE_RESULT_OK_CACHE state. The state of the node is OK whether retrieved from the cache or not, and the cache state can already be gleaned from the stat flags
- remove NODE_RESULT_OK_CACHE state. The state of the node is OK whether retrieved from the cache or not, and the cache state can already be gleaned from the stat flags
- make enum a class enum and modernize naming
- fix issues with executable path preventing test from working and enable test
- remove disabling of -Wc++17-extensions (we use c++17 everywhere now) - remove old references to Clang 3/pre-Clang 6 which is no longer supported on any platform FASTBuild can still invoke older versions of clang - but it requires C++17 and newer versions to be built from source.
- Make cancelled tasks an explicit concept - Extend tests to cover various scenarios
- set in FBuildTestOptions so it doesn't need to be set per-test
- FBuildTestOptions already configures the port
[Fix] Fix typo in Error 1035 regarding exessive depth complexity [Fix] Fix typo in build-time errors regarding VCXProjExternal config problems
[Improvement] Optimize startup time by avoiding unnecessary work during DB loading - avoid setting the build pass tag during loading as it's not used (it's only needed when saving) [Improvement] Optimize startup time after bff edits by avoiding unnecessary work during DB migration - utilize the already calculated node name hash in various find and create calls when migrating nodes - avoid unnecesdsarily sanitizing file names when migrating the DB by using a different CreateNode call [Note] DB version changed
- in "cl mode" Clang on Windows emulates MSVC and creates an additional object for the pch which needs to be linked in
- make DeleteDeletor the default (using new/delete rather than alloc/free) - rename Release() to ReleaseOwnership() for clarity
… used - LightCache was incorrecly using the "final" args, which is just one arg referencing the repsonse file, which meant all the normal args were unavailable for things like include path resolution - It now uses the "raw" args, which are the real args and a test is added to cover this behavior
…nt with OSX & Linux)
- de-duplicate code into helper function - extend test to cover quoted arg where quotes don't surround entire arg
[Note] Arg processing has been overhauled or correctness and consistency and fixes may invalidate some previous work-around [Fix] Escaped quotes are correctly handled in process arguments [Fix] Quotes are properly tokenized regardless of quote position [Fix] Args with quotes and spaces are correctly tokenized [Fix][OSX][Linux] Args with quotes are handled correctly when spawning processes
- arg tokenization was recently fixed which means compdb got some fixes automatically, but the code was using some custom quote handlign logic which was incorect. That now uses the standardized logic in AString. - tests are extended slightly to cover strings with spaces in them
- avoid node lookup for alias resoluation when we have the node available already - tidy up optional arguments by wrapping in a helper structure
…ths (regression in v1.12) - search params were not correctly encoding excludePaths into the directory listing, so different results were incorectly collapsed - fix the encoding error and add test coverage for directory listing node name generation
- we don't need RTTI - hoist Windows settings out of "optimizations" into base compiler setup for consistency
- we don't care about the contents of the buffer, but MSan configs flags this use so we want to fix that
- reduce repeats. One repeat is enough for these tests and these tests are slow in these configs
…faults (~5%) - update to Zstd 1.5.6
…~5%) - update to LZ4 to 1.10.0
- escaping logic was wrong and quoting in the output was missing - the desired logic does seem to be the same as for filenames, so the functionality is now unified
- args were processes using naive quote handling instead of the more complex logic that accounts for escaped slashes - extend tests to cover
- remove reliance on complier/platforms specific init order tweaks and use atexit for shutdown leak detection - emit non-zero return code (99) when application exits with leaks - change how tests detect leaks to avoid covering up application-wide leaks
- some strings were inconsistently handled, resulting in missing or duplicate quotes - unify all string handling behavior
- remove unnecessary use of exceptions
- use "strip-unneeded" instead of "strip-debug"
- extract debug symbols - dead strip unused code - ensure CI configuration matches others with rtti disabled
- disable RTTI - disable exceptions This makes the special CI config match other configs.
- return non-zero on failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate development branch to main