Skip to content

🐛 Fix support for UnionType with Python 3.11#676

Closed
standag wants to merge 3 commits intofastapi:masterfrom
standag:standa/fix/533
Closed

🐛 Fix support for UnionType with Python 3.11#676
standag wants to merge 3 commits intofastapi:masterfrom
standag:standa/fix/533

Conversation

@standag
Copy link

@standag standag commented Oct 3, 2023 •
edited
Loading

Resolves #533

@thomasaarholt
Copy link

thomasaarholt commented Oct 9, 2023

This worked like a charm! Thank you!

@adam-moss
Copy link

adam-moss commented Oct 13, 2023

This is a very nice addition 👍

@coreegor
Copy link

coreegor commented Oct 16, 2023

Hello everyone,
Is there any plan on having this merged ?
@standag can you set an assignee ?

@standag
Copy link
Author

standag commented Oct 16, 2023

Sorry, I cannot, I haven't write access to this repository.

@peidrao
Copy link

peidrao commented Oct 18, 2023

The PR seems wonderful, why hasn't it been added yet?

@coreegor
Copy link

coreegor commented Oct 26, 2023

@standag So you can't set @tiangolo as the assignee ?

@standag
Copy link
Author

standag commented Oct 26, 2023

Who can use this feature
Anyone with write access to a repository can assign issues and pull requests.
https://docs.github.com/en/issues/tracking-your-work-with-issues/assigning-issues-and-pull-requests-to-other-github-users

@disrupted
Copy link

disrupted commented Oct 26, 2023

also resolves #348

@potatoeggy potatoeggy mentioned this pull request Dec 31, 2023
Closed
@aronbierbaum
Copy link

aronbierbaum commented Jan 9, 2024

Are there any updates on this pull request. Would love to not need to use Optional or Union.

@johnthagen johnthagen mentioned this pull request Jan 16, 2024
Closed
7 tasks
@tino
Copy link

tino commented Jan 26, 2024

@disrupted is @tiangolo the only one that can merge? Seems a bit wasteful that this is sitting here with 2 approves and a passing CI just waiting.

@disrupted
Copy link

disrupted commented Jan 26, 2024

@disrupted is @tiangolo the only one that can merge? Seems a bit wasteful that this is sitting here with 2 approves and a passing CI just waiting.

Looks like it. My review only has symbolic value as I am not a maintainer.

@svlandeg
Copy link
Member

svlandeg commented Feb 29, 2024

Related PR: #548

@svlandeg svlandeg added feature New feature, enhancement or request types Type hints and type checking p3 labels Feb 29, 2024
This was referenced Mar 24, 2024
Merged
Closed
@jonaslb jonaslb mentioned this pull request Mar 29, 2024
Merged
@sebastian-correa
Copy link

sebastian-correa commented Apr 10, 2024

Will this be merged anytime soon? @tiangolo

This has become a sore point with Typer in our code.

@svlandeg svlandeg added bug Something isn't working and removed p3 labels Apr 11, 2024
@svlandeg svlandeg added p2 and removed feature New feature, enhancement or request labels Apr 11, 2024
@svlandeg svlandeg changed the title fix: add support for UnionType annotation 🐛 Fix support for UnionType with Python 3.11 Apr 11, 2024
svlandeg
svlandeg approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that this behaviour works in 3.10 but broke in 3.11, and the unit test introduced in this PR captures the bug nicely.

The fix is very clean and minimal, using the variables from _typing that were introduced precisely for this type of usage.

Thanks for the contribution @standag!

@svlandeg
Copy link
Member

svlandeg commented Apr 11, 2024 •
edited
Loading

Update: #548 now contains all the changes that are also in this PR, as well as a few additional rewrites. As such, I recommend to merge #548 and close this one, but I'll leave the final decision with Tiangolo.

@svlandeg svlandeg linked an issue Apr 11, 2024 that may be closed by this pull request
PEP 604 Support #348
Closed
7 tasks
@svlandeg svlandeg mentioned this pull request Apr 11, 2024
Closed
7 tasks
@svlandeg svlandeg linked an issue Apr 11, 2024 that may be closed by this pull request
TypeError: unsupported operand type(s) for |: 'type' and 'NoneType' #371
Closed
7 tasks
@johnthagen johnthagen mentioned this pull request May 2, 2024
Open
3 tasks
ml31415
ml31415 approved these changes May 29, 2024
View reviewed changes
Copy link

@ml31415 ml31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please merge.

@ml31415
Copy link

ml31415 commented May 29, 2024

Dear Sebastian @tiangolo ,
please consider adding one or two trusted persons as maintainers for this package. Python 3.13 is about to come out and this issue for py3.11 is still not fixed, despite long time opened pull requests. I have full understanding for being busy or losing interest in maintenance for a package after a while. But the community is here to help out, to keep this package going. Please just let the community do it's job!

@tiangolo
Copy link
Member

tiangolo commented Aug 17, 2024

Thank you for the work @standag! ☕

And thanks @svlandeg for all the help 🙇

This should have been fixed by #548

It is now available in Typer 0.12.4 🚀

Given that, I'll close this one.

@tiangolo tiangolo closed this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svlandeg svlandeg svlandeg approved these changes

+3 more reviewers

@ml31415 ml31415 ml31415 approved these changes

@disrupted disrupted disrupted approved these changes

@peidrao peidrao peidrao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working p2 types Type hints and type checking

Projects

None yet

Milestone

No milestone