Skip to content

Support for typing.Literal as an alternative to Enum in Python 3.8+. #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost wants to merge 1 commit into from
Closed

Support for typing.Literal as an alternative to Enum in Python 3.8+. #174

ghost wants to merge 1 commit into from

Conversation

@ghost
Copy link

@ghost ghost commented Oct 8, 2020

Support for typing.Literal for creating choices, without actually having to create Enum types. Requires Python 3.8, referenced in #76. I ran tests again 3.6 without problems, so I think the version check if working OK.

@codecov
Copy link

codecov bot commented Oct 8, 2020 •
edited
Loading

Codecov Report

Merging #174 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #174   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          242       244    +2     
  Lines         4508      4545   +37     
=========================================
+ Hits          4508      4545   +37
Impacted Files Coverage Δ
docs_src/parameter_types/enum/tutorial003.py 100.00% <100.00%> (ø)
...test_parameter_types/test_enum/test_tutorial003.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a4c72...09d56ba. Read the comment docs.

@carlthome
Copy link

carlthome commented Oct 26, 2020

Status on this PR @sretlawd? Changes LGTM but only skimmed them.

@sdrave sdrave mentioned this pull request Nov 17, 2020
Merged
@blackary
Copy link
Contributor

blackary commented May 14, 2021

Friendly ping -- this would be a very nice feature to have.

@lukaszmoroz
Copy link

lukaszmoroz commented Sep 17, 2021

Hey it's been a year already, is there anything blocking this PR or is the project not maintained anymore? I'll allow myself ping @tiangolo

@arogozhnikov arogozhnikov mentioned this pull request Dec 21, 2021
Closed
@ghost
Copy link

ghost commented Dec 21, 2021

This looks really good. I'd like this!

@OskarZyg
Copy link

OskarZyg commented May 1, 2022

What happened with this PR?

@svlandeg
Copy link
Member

svlandeg commented May 2, 2022

What happened with this PR?

It looks like the original submitter removed their account, and Github then automatically closed this PR, as the edits don't seem to be available anymore :(

@blackary blackary mentioned this pull request Jul 14, 2022
Merged
@svlandeg
Copy link
Member

svlandeg commented Jun 3, 2024

[Update]: This work has been continued in PR #429

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@carlthome @blackary @lukaszmoroz @OskarZyg @svlandeg @dwalters