Skip to content

🐛 Fix inspect.getcoroutinefunction() can break testing with unittest.mock.patch() #14022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiangolo merged 3 commits into from
Sep 20, 2025
Merged

🐛 Fix inspect.getcoroutinefunction() can break testing with unittest.mock.patch() #14022

tiangolo merged 3 commits into from
Sep 20, 2025

Conversation

@secrett2633
Copy link
Contributor

@secrett2633 secrett2633 commented Aug 30, 2025

Description

This issue is related to a known Python bug that was fixed in Python 3.13 but has not been backported to earlier versions: python/cpython#94924
As a workaround for versions prior to Python 3.13, we could consider using conditional imports based on the Python version:

Resolves #14021

if sys.version_info < (3, 13):
    from asyncio import iscoroutinefunction
else:
    from inspect import iscoroutinefunction

Example Code

import sys
import asyncio
import inspect
from unittest.mock import create_autospec, patch

print(f"Python version: {sys.version_info[:2]}") # (3, 12)

async def foo():
    pass

mock_autospec = create_autospec(foo)
print(asyncio.iscoroutinefunction(mock_autospec)) # True
print(inspect.iscoroutinefunction(mock_autospec)) # False

with patch('__main__.foo', autospec=True) as mock_foo:
    print(asyncio.iscoroutinefunction(mock_foo)) # True
    print(inspect.iscoroutinefunction(mock_foo)) # False

@edgarrmondragon edgarrmondragon mentioned this pull request Aug 31, 2025
Closed
@YuriiMotov YuriiMotov changed the title 🐛 Fix inspect.getcoroutinefunction() can break testing with unittest.mock.patch() 🐛 Fix inspect.getcoroutinefunction() can break testing with unittest.mock.patch() Aug 31, 2025
@YuriiMotov YuriiMotov added the bug Something isn't working label Aug 31, 2025
YuriiMotov
YuriiMotov approved these changes Aug 31, 2025
View reviewed changes
Copy link
Member

@YuriiMotov YuriiMotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

tiangolo
tiangolo approved these changes Sep 20, 2025
View reviewed changes
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! 🚀 🍰

@tiangolo tiangolo merged commit c831cdb into fastapi:master Sep 20, 2025
31 of 32 checks passed
@evnchn evnchn mentioned this pull request Oct 9, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiangolo tiangolo tiangolo approved these changes

@YuriiMotov YuriiMotov YuriiMotov approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@secrett2633 @tiangolo @YuriiMotov