Skip to content

Conversation

@urushio
Copy link
Contributor

@urushio urushio commented Dec 25, 2023

No description provided.

@tiangolo
Copy link
Member

📝 Docs preview for commit 036e8af at: https://52a3fe25.fastapitiangolo.pages.dev

Copy link
Contributor

@Jamim Jamim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @urushio,

Nice catch! But there are many more onwers to fix 😅

$ ag Onwer
docs/en/docs/release-notes.md
45:        raise HTTPException(status_code=400, detail=f"Onwer error: {e}")

tests/test_tutorial/test_dependencies/test_tutorial008b.py
17:    assert response.json() == {"detail": "Onwer error: Rick"}

tests/test_tutorial/test_dependencies/test_tutorial008b_an.py
17:    assert response.json() == {"detail": "Onwer error: Rick"}

tests/test_tutorial/test_dependencies/test_tutorial008b_an_py39.py
17:    assert response.json() == {"detail": "Onwer error: Rick"}

docs_src/dependencies/tutorial008b.py
20:        raise HTTPException(status_code=400, detail=f"Onwer error: {e}")

docs_src/dependencies/tutorial008b_an_py39.py
22:        raise HTTPException(status_code=400, detail=f"Onwer error: {e}")

docs_src/dependencies/tutorial008b_an.py
21:        raise HTTPException(status_code=400, detail=f"Onwer error: {e}")

@urushio urushio changed the title Fix typo for docs_src/dependencies/tutorial008b.py Fix typo in documents Dec 26, 2023
@tiangolo
Copy link
Member

📝 Docs preview for commit 66d92ee at: https://91f23638.fastapitiangolo.pages.dev

Copy link
Contributor

@hasansezertasan hasansezertasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am with @Jamim, can you also fix those?

@nilslindemann
Copy link
Contributor

I think he already has fixed all seven.

@hasansezertasan
Copy link
Contributor

@nilslindemann I just double-checked it and there are no onwers anymore.

@urushio
Copy link
Contributor Author

urushio commented Dec 27, 2023

Another pull request and commit fixed the same location, so I closed this pull request.
#10847
040ad98

@urushio urushio closed this Dec 27, 2023
@urushio urushio deleted the docs-patch branch December 27, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants