ChannelsLast Callback Improvements, Additional Documentation, & Bug Fix#3876
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Member
|
Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upstreams my ChannelsLast callback from fastxtend. This version of the callback is simpler, and it fixes the current
ChannelsLastcallback bug of adding the labels to the model input batch.The new Channels Last notebook adds two convenience methods for enabling and disabling channels last (
to_channelslastandto_contiguous), addingMixedPrecisionby default for best channels last performance. It also expands the channels last documentation and adds a test to make sure model outputs are in channels last format.Keeping with the current
MixedPrecisionbehavior, I modifiedload_learnerto remove theChannelsLastandMixedPrecisoncallbacks.I also moved the Mixed Precision and Channels Last notebooks under the Training sidebar header for easier visibility, since they struck me as more similar to the Distributed Trainer notebook, which is directly under Training, than other callbacks.