Fix warnings during GAN training#3334
Open
AndreyYashkin wants to merge 2 commits into
Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jph00
requested changes
Apr 30, 2021
jph00
left a comment
Member
There was a problem hiding this comment.
Instead of changing things to store in the Learner, let's instead rename to avoid name conflicts. I suggest adding a gan_ prefix as shown. You'll also need to update the usages of these names throughout the class to add the prefix. Many thanks for your PR!
| "Initialize smootheners." | ||
| self.generator,self.critic = self.model.generator,self.model.critic | ||
| self.gen_mode = self.gen_first | ||
| self.learn.generator,self.learn.critic = self.model.generator,self.model.critic |
Member
There was a problem hiding this comment.
Suggested change
| self.learn.generator,self.learn.critic = self.model.generator,self.model.critic | |
| self.gan_generator,self.gan_critic = self.model.generator,self.model.critic |
| self.generator,self.critic = self.model.generator,self.model.critic | ||
| self.gen_mode = self.gen_first | ||
| self.learn.generator,self.learn.critic = self.model.generator,self.model.critic | ||
| self.learn.gen_mode = self.gen_first |
Member
There was a problem hiding this comment.
Suggested change
| self.learn.gen_mode = self.gen_first | |
| self.gan_gen_mode = self.gen_first |
Author
|
My apologies for the late reply. I was too busy last weeks and could not find free time to update and check my patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue is described in #3222
According to Callback documentation "Callbacks provide a shortcut to avoid having to write self.learn.bla for any bla attribute we seek; instead, just write self.bla. This only works for getting attributes, not for setting them."