Restore column when near eof#35
Merged
farmergreg merged 1 commit intofarmergreg:masterfrom May 18, 2024
faergeek:restore-column-when-near-eof
Merged
Restore column when near eof#35farmergreg merged 1 commit intofarmergreg:masterfrom faergeek:restore-column-when-near-eof
farmergreg merged 1 commit intofarmergreg:masterfrom
faergeek:restore-column-when-near-eof
Conversation
Owner
|
Thanks for the pull request! I'll try to test it out this weekend. You may have resolved a long standing bug. thanks! If anyone else happens to test, please post your results here. |
Owner
|
Thanks for the bug fix! This has been an issue for years, and thanks to your eagle-eyed diligence, it is now squashed! Crazy how tiny details matter in our profession! This particular bug has bitten me a number of times. Thanks for fixing it! |
Contributor
Author
|
Awesome! Thank you for maintaining this plugin for so long 👍 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for this very useful plugin 👍
The only thing that bothered me a bit is that it uses quote instead of backtick when we're near the end of the file, which means it jumps to first non-blank character (so not restoring the column position). Seems like it was like that right from it's introduction in 2015 (945cc1a), but I'm not sure if it's actually intended to behave like that for some reason.