Merged
Conversation
83a67b0 to
0f43658
Compare
2e47b84 to
1d612a4
Compare
1d612a4 to
6252524
Compare
95381dc to
6328f20
Compare
nico-famedly
approved these changes
Apr 10, 2025
Member
nico-famedly
left a comment
There was a problem hiding this comment.
Looks good to me, but I didn't test it yet. Long term we might want to integrate otlp better by removing the opentracing support and reorganizing some things to allow dynamic tracing of endpoints, but for now this looks good. Thanks a lot!
6328f20 to
1556930
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remaining todos:
Metrics will be done in a separate PR.
This PR does nothing without explicit configuration.
Add this to homeserver.yaml:
Add this to your log config YAML:
Note that the logging OtlpHandler does not use a formatter, because it is designed for structured logging.
Then, set the otlp endpoint using environment variables (e.g.,
OTEL_EXPORTER_OTLP_ENDPOINT).