Skip to content

--performance table omits the duplication stage timing #257

@OmerGronich

Description

@OmerGronich

What happened?

fallow --performance prints two timing tables: Pipeline Performance and Health Pipeline Performance. Neither includes the duplication stage. On a repo with code clones the duplication stage is often the largest single cost, but its time appears only as a parenthetical in the human-readable output (✗ N lines duplicated ... (8.4s)), which is easy to miss when looking at the perf table for hot stages.

Reproduction

Run fallow --no-cache --performance on any TS/JS repository where the duplication check produces output. The Pipeline Performance table prints rows for discover files, workspaces, plugins, script analysis, parse/extract, cache update, entry points, resolve imports, build graph, analyze, TOTAL — but no duplication row.

The duplication time only appears in the body output, e.g. ✗ 320 lines (27.6%) duplicated across 4 files (0.01s), separate from the table.

Expected behavior

Pipeline Performance should include a duplication: <ms> row (or per-sub-stage rows: dupes/tokenize, dupes/suffix_array, dupes/lcp, dupes/ranking) so the breakdown matches the actual work fallow performs.

Fallow version

fallow 2.60.0

Operating system

macOS

Configuration

default

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions