Skip to content

Stack overflow analyzing microsoft/TypeScript unless RUST_MIN_STACK is increased #247

@OmerGronich

Description

@OmerGronich

What happened?

Running Fallow on microsoft/TypeScript (https://github.com/microsoft/Typescript) aborts with a Rust stack overflow in dead-code and health.

thread '<unknown>' has overflowed its stack
fatal runtime error: stack overflow, aborting

dupes completes, so this appears isolated to the dead-code/health path.

Increasing the Rust stack makes the same commands complete successfully:

RUST_MIN_STACK=16777216 fallow --only dead-code --performance --summary
TOTAL: 2714.3ms
Dead Code: 2.76s

health also completes with the same workaround:

TOTAL: 3122.2ms
Health: 3.12s

Reproduction

git clone --depth 1 https://github.com/microsoft/TypeScript.git
cd TypeScript
fallow --only dead-code --performance --summary

Isolation:

fallow --only dead-code  -> stack overflow
fallow --only health     -> stack overflow
fallow --only dupes      -> completes (~45.8s)

Expected behavior

Fallow should not abort with a stack overflow. It should complete or report a normal diagnostic/error.

Fallow version

2.58.0

Operating system

macOS

Configuration

No Fallow config.

Note: dependencies were not installed; Fallow warned that `node_modules` was missing. The crash still seems useful because increasing `RUST_MIN_STACK` makes the same source tree complete.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions