chore(drivers): add a warning for not officially supported archs#421
Merged
poiana merged 1 commit intofalcosecurity:masterfrom Jun 27, 2022
Merged
Conversation
fae8122 to
973b32f
Compare
FedeDP
previously approved these changes
Jun 22, 2022
Contributor
FedeDP
left a comment
There was a problem hiding this comment.
/approve
IMHO this is a big step forward: declaring the officially supported architectures with a cmake warning is the best possible.
Contributor
|
LGTM label has been added. DetailsGit tree hash: 7fddc769352f93242bacf23b00d513a2510ed7ee |
5 tasks
15 tasks
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
973b32f to
7491566
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
LGTM label has been added. DetailsGit tree hash: d8ece2a8ef04f3f1b92171a9a709d4e59e72c1e9 |
Contributor
|
/cc @leogr |
leogr
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrea Terzolo andrea.terzolo@polito.it
What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
This pull request wants to clarify which are officially supported. This doesn't mean that all other architectures won't work it only suggest that we are focusing our efforts on the officially supported ones.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: