Skip to content

sync: cherry-pick for release/0.23.x#2766

Merged
poiana merged 1 commit intofalcosecurity:masterfrom
ekoops:ekoops/sync-release-0.23.x
Dec 22, 2025
Merged

sync: cherry-pick for release/0.23.x#2766
poiana merged 1 commit intofalcosecurity:masterfrom
ekoops:ekoops/sync-release-0.23.x

Conversation

@ekoops
Copy link
Copy Markdown
Contributor

@ekoops ekoops commented Dec 22, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR cherry-picks from master the content of the following merged PRs:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/milestone 0.23.0

Does this PR introduce a user-facing change?:

NONE

@fremmi @ekoops
fix(userspace/libsinsp): prevent infinite loop in ancillary data pars…
c085048 
…ing due to integer overflow

Add validation in ppm_cmsg_nxthdr to ensure cmsg_aligned_len is at least
sizeof(ppm_cmsghdr) after alignment calculation. This prevents an infinite
loop when malformed ancillary data contains cmsg_len = 0xFFFFFFFFFFFFFFFF,
which causes integer overflow in PPM_CMSG_ALIGN macro, resulting in
cmsg_aligned_len = 0 and preventing forward progress in the loop.

Signed-off-by: Francesco Emmi <francesco.emmi@sysdig.com>
@poiana poiana added this to the 0.23.0 milestone Dec 22, 2025
@poiana poiana added dco-signoff: yes kind/sync PRs syncing branch with changes coming from another branch labels Dec 22, 2025
@ekoops ekoops changed the title sync: cherry-pick for release 0.22.x sync: cherry-pick for release/0.22.x Dec 22, 2025
@ekoops ekoops mentioned this pull request Dec 22, 2025
Closed
15 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 22, 2025

Perf diff from master - unit tests

    16.89%     -7.51%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_add_ref_lock_nothrow()
     8.29%     +5.02%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::_M_get_use_count() const
    13.28%     +3.03%  [.] std::__shared_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2>::__shared_ptr(std::__weak_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     6.73%     +2.32%  [.] sinsp_threadinfo::update_main_fdtable()
     9.66%     -1.73%  [.] sinsp_threadinfo::get_fd_table()
     5.02%     -0.27%  [.] thread_group_info::get_first_thread() const
    10.09%     -0.20%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release()
     3.73%     -0.20%  [.] sinsp_thread_manager::create_thread_dependencies(std::shared_ptr<sinsp_threadinfo> const&)
     0.04%     +0.08%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::operator=(std::__shared_count<(__gnu_cxx::_Lock_policy)2> const&)
     0.20%     -0.07%  [.] void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>(char const*, char const*, std::forward_iterator_tag)

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0070         +0.0069           239           240           239           240
BM_sinsp_split_median                                          +0.0037         +0.0036           239           240           239           240
BM_sinsp_split_stddev                                          +1.5056         +1.5316             2             4             2             4
BM_sinsp_split_cv                                              +1.4883         +1.5141             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.1014         -0.1014            76            69            76            69
BM_sinsp_concatenate_paths_relative_path_median                -0.1006         -0.1010            76            69            76            69
BM_sinsp_concatenate_paths_relative_path_stddev                -0.0765         -0.0746             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    +0.0278         +0.0298             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0277         -0.0278            41            40            41            40
BM_sinsp_concatenate_paths_empty_path_median                   -0.0545         -0.0545            42            40            42            40
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.2444         -0.2479             1             1             1             1
BM_sinsp_concatenate_paths_empty_path_cv                       -0.2229         -0.2264             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0824         -0.0824            74            68            74            68
BM_sinsp_concatenate_paths_absolute_path_median                -0.0831         -0.0832            74            68            74            68
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.6470         -0.6509             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.6153         -0.6196             0             0             0             0

@poiana poiana added the lgtm label Dec 22, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.57%. Comparing base (9b8a8e4) to head (c085048).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
userspace/libsinsp/parsers.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2766      +/-   ##
==========================================
- Coverage   74.57%   74.57%   -0.01%     
==========================================
  Files         292      292              
  Lines       30025    30026       +1     
  Branches     4657     4658       +1     
==========================================
  Hits        22392    22392              
- Misses       7633     7634       +1
Flag Coverage Δ
libsinsp 74.57% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

deepskyblue86
deepskyblue86 approved these changes Dec 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@deepskyblue86 deepskyblue86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Dec 22, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepskyblue86, ekoops, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [deepskyblue86,ekoops,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 9e6a8cc into falcosecurity:master Dec 22, 2025
46 of 47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Dec 22, 2025
@ekoops
Copy link
Copy Markdown
Contributor Author

ekoops commented Dec 22, 2025

I don't know what happened here. I'm pretty sure I selected the right branch, but this appears to be merged on master. I'm gonna open another PR

@ekoops ekoops changed the title sync: cherry-pick for release/0.22.x sync: cherry-pick for release/0.23.x Dec 22, 2025
@ekoops ekoops deleted the ekoops/sync-release-0.23.x branch December 22, 2025 14:34
@BrewTestBot BrewTestBot mentioned this pull request Dec 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leogr leogr leogr approved these changes

@deepskyblue86 deepskyblue86 deepskyblue86 approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@terror96 terror96 Awaiting requested review from terror96

Assignees

@leogr leogr

@deepskyblue86 deepskyblue86

Labels

approved area/libsinsp dco-signoff: yes kind/sync PRs syncing branch with changes coming from another branch lgtm release-note-none size/XS

Projects

Falco Roadmap
Status: Done

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ekoops @poiana @leogr @deepskyblue86 @fremmi