Skip to content

chore(userspace/libsinsp): remove unused update-cri-proto file#2753

Merged
poiana merged 1 commit intofalcosecurity:masterfrom
ekoops:ekoops/remove-update-cri-proto
Dec 15, 2025
Merged

chore(userspace/libsinsp): remove unused update-cri-proto file#2753
poiana merged 1 commit intofalcosecurity:masterfrom
ekoops:ekoops/remove-update-cri-proto

Conversation

@ekoops
Copy link
Copy Markdown
Contributor

@ekoops ekoops commented Dec 15, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR removes the unused update-cri-proto file. This file used to update the CRI protobuf dependency used by the old container engines support. The support is now moved into a separate container plugin, and interaction between the plugin and CRI is handled through the Golang dependency system. This means that we can remove this file, since it is not used anymore by any component.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/milestone 0.23.0

Does this PR introduce a user-facing change?:

NONE

@ekoops
chore(userspace/libsinsp): remove unused update-cri-proto file
216d92c 
This file used to update the CRI protobuf dependency used by the old
container engines support. The support is now moved into a separate
container plugin, and interaction between the plugin and CRI is
handled through the Golang dependency system. This means that it is
possible to remove this file, since it is not used anymore by any
component.

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@poiana poiana added this to the 0.23.0 milestone Dec 15, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 15, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.56%. Comparing base (928478d) to head (216d92c).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2753   +/-   ##
=======================================
  Coverage   74.56%   74.56%           
=======================================
  Files         292      292           
  Lines       29998    29998           
  Branches     4651     4651           
=======================================
  Hits        22367    22367           
  Misses       7631     7631
Flag Coverage Δ
libsinsp 74.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 15, 2025

Perf diff from master - unit tests

     3.55%    +21.37%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_add_ref_lock_nothrow()
     4.53%     +9.67%  [.] std::__shared_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2>::__shared_ptr(std::__weak_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     6.08%     +7.67%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release()
     4.24%     +7.61%  [.] sinsp_threadinfo::get_main_thread()
     3.19%     +6.22%  [.] sinsp_threadinfo::get_fd_table()
     3.39%     +5.74%  [.] sinsp_threadinfo::update_main_fdtable()
     2.12%     +5.65%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count(std::__weak_count<(__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
    11.59%     -5.43%  [.] sinsp::next(sinsp_evt**)
     1.86%     +4.59%  [.] thread_group_info::get_first_thread() const
     7.35%     -3.40%  [.] sinsp_parser::reset(sinsp_evt&) const

Heap diff from master - unit tests

peak heap memory consumption: 27.68K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0011         -0.0011           248           247           247           247
BM_sinsp_split_median                                          -0.0011         -0.0011           248           247           247           247
BM_sinsp_split_stddev                                          +0.2623         +0.2247             1             2             1             2
BM_sinsp_split_cv                                              +0.2637         +0.2261             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0345         +0.0345            70            72            70            72
BM_sinsp_concatenate_paths_relative_path_median                +0.0318         +0.0318            70            72            69            72
BM_sinsp_concatenate_paths_relative_path_stddev                +0.1291         +0.1286             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    +0.0914         +0.0910             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0459         -0.0459            44            42            44            42
BM_sinsp_concatenate_paths_empty_path_median                   -0.0276         -0.0277            44            42            44            42
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.0309         +0.0358             1             1             1             1
BM_sinsp_concatenate_paths_empty_path_cv                       +0.0805         +0.0857             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0229         +0.0229            71            73            71            73
BM_sinsp_concatenate_paths_absolute_path_median                +0.0215         +0.0216            71            73            71            73
BM_sinsp_concatenate_paths_absolute_path_stddev                +1.0493         +1.0719             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    +1.0034         +1.0255             0             0             0             0

leogr
leogr approved these changes Dec 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@poiana poiana added the lgtm label Dec 15, 2025
irozzo-1A
irozzo-1A approved these changes Dec 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@irozzo-1A irozzo-1A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Dec 15, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3590524 into falcosecurity:master Dec 15, 2025
47 of 48 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Dec 15, 2025
@ekoops ekoops deleted the ekoops/remove-update-cri-proto branch December 17, 2025 12:08
@BrewTestBot BrewTestBot mentioned this pull request Dec 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leogr leogr leogr approved these changes

@irozzo-1A irozzo-1A irozzo-1A approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@leogr leogr

@irozzo-1A irozzo-1A

Labels

approved area/libsinsp dco-signoff: yes kind/cleanup lgtm release-note-none size/M

Projects

Falco Roadmap
Status: Done

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ekoops @poiana @leogr @irozzo-1A