Skip to content

chore(libsinsp): add missing dependencies to sinsp_test_support#2750

Merged
poiana merged 1 commit intofalcosecurity:masterfrom
irozzo-1A:fix-sinsp-rest-support-deps
Dec 12, 2025
Merged

chore(libsinsp): add missing dependencies to sinsp_test_support#2750
poiana merged 1 commit intofalcosecurity:masterfrom
irozzo-1A:fix-sinsp-rest-support-deps

Conversation

@irozzo-1A
Copy link
Copy Markdown
Contributor

@irozzo-1A irozzo-1A commented Dec 12, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Add missing dependencies to the sinsp_test_support target to be used for writing integration tests for plugins.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 12, 2025 •
edited
Loading

Perf diff from master - unit tests

     3.26%    +18.01%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_add_ref_lock_nothrow()
     4.17%    +10.76%  [.] std::__shared_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2>::__shared_ptr(std::__weak_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     3.90%     +8.45%  [.] sinsp_threadinfo::get_main_thread()
     2.93%     +7.50%  [.] sinsp_threadinfo::get_fd_table()
     5.58%     +6.44%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release()
    10.65%     -5.38%  [.] sinsp::next(sinsp_evt**)
     3.12%     +5.22%  [.] sinsp_threadinfo::update_main_fdtable()
     3.33%     +4.89%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::_M_get_use_count() const
     1.95%     +4.83%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count(std::__weak_count<(__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     1.71%     +4.63%  [.] thread_group_info::get_first_thread() const

Heap diff from master - unit tests

peak heap memory consumption: 27.68K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0469         -0.0470           248           236           247           236
BM_sinsp_split_median                                          -0.0474         -0.0474           248           236           247           236
BM_sinsp_split_stddev                                          -0.3185         -0.3426             1             1             1             1
BM_sinsp_split_cv                                              -0.2850         -0.3102             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0219         -0.0220            70            68            70            68
BM_sinsp_concatenate_paths_relative_path_median                -0.0145         -0.0145            70            69            69            68
BM_sinsp_concatenate_paths_relative_path_stddev                -0.0434         -0.0427             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    -0.0220         -0.0212             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0611         -0.0611            44            41            44            41
BM_sinsp_concatenate_paths_empty_path_median                   -0.0649         -0.0649            44            41            44            41
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.5527         +0.5526             1             1             1             1
BM_sinsp_concatenate_paths_empty_path_cv                       +0.6538         +0.6536             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0432         -0.0433            71            68            71            68
BM_sinsp_concatenate_paths_absolute_path_median                -0.0448         -0.0447            71            68            71            68
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.8845         +0.9066             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.9696         +0.9930             0             0             0             0

@irozzo-1A
chore(libsinsp): add missing dependencies to sinsp_test_support
ca96d49 
Add missing dependencies to the sinsp_test_support target to be used for
writing integration tests for plugins.

Signed-off-by: irozzo-1A <iacopo@sysdig.com>
@irozzo-1A irozzo-1A force-pushed the fix-sinsp-rest-support-deps branch from c6a66a0 to ca96d49 Compare December 12, 2025 11:30
@irozzo-1A
Copy link
Copy Markdown
Contributor Author

irozzo-1A commented Dec 12, 2025

xref: https://github.com/falcosecurity/plugins/actions/runs/20138004839/job/57879172147?pr=1126

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.56%. Comparing base (d694e25) to head (ca96d49).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2750   +/-   ##
=======================================
  Coverage   74.56%   74.56%           
=======================================
  Files         292      292           
  Lines       29998    29998           
  Branches     4651     4651           
=======================================
  Hits        22367    22367           
  Misses       7631     7631
Flag Coverage Δ
libsinsp 74.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

terror96
terror96 approved these changes Dec 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@terror96 terror96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana poiana added the lgtm label Dec 12, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Dec 12, 2025

LGTM label has been added.

DetailsGit tree hash: 01a8ddf5a977f7f77af432a985e1ffbe53d781d1

ekoops
ekoops approved these changes Dec 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ekoops ekoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Dec 12, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Dec 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A, terror96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ekoops ekoops added this to the 0.23.0 milestone Dec 12, 2025
@poiana poiana merged commit 83c6a83 into falcosecurity:master Dec 12, 2025
47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Dec 12, 2025
@BrewTestBot BrewTestBot mentioned this pull request Dec 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terror96 terror96 terror96 approved these changes

@ekoops ekoops ekoops approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@terror96 terror96

@ekoops ekoops

Labels

approved area/build dco-signoff: yes kind/bug Something isn't working lgtm release-note-none size/XS

Projects

Falco Roadmap
Status: Done

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@irozzo-1A @poiana @terror96 @ekoops