Skip to content

ci: add install-bpftool composite action#2748

Merged
poiana merged 1 commit intofalcosecurity:masterfrom
ekoops:ekoops/ci-install-bpftool
Dec 11, 2025
Merged

ci: add install-bpftool composite action#2748
poiana merged 1 commit intofalcosecurity:masterfrom
ekoops:ekoops/ci-install-bpftool

Conversation

@ekoops
Copy link
Copy Markdown
Contributor

@ekoops ekoops commented Dec 11, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR introduces a dedicated composite action for bpftool installation. This promotes reuse.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/milestone 0.23.0

Does this PR introduce a user-facing change?:

NONE

@poiana poiana added this to the 0.23.0 milestone Dec 11, 2025
@ekoops ekoops force-pushed the ekoops/ci-install-bpftool branch from 43a1c08 to e0af3fe Compare December 11, 2025 13:09
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 11, 2025 •
edited
Loading

Perf diff from master - unit tests

     4.17%    +12.70%  [.] std::__shared_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2>::__shared_ptr(std::__weak_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     3.34%    +11.24%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::_M_get_use_count() const
     3.90%     +9.28%  [.] sinsp_threadinfo::get_main_thread()
     3.27%     +8.26%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_add_ref_lock_nothrow()
     3.12%     +7.39%  [.] sinsp_threadinfo::update_main_fdtable()
     5.60%     +6.71%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release()
     2.93%     +6.22%  [.] sinsp_threadinfo::get_fd_table()
    10.67%     -5.41%  [.] sinsp::next(sinsp_evt**)
     1.95%     +5.08%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count(std::__weak_count<(__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     1.71%     +3.40%  [.] thread_group_info::get_first_thread() const

Heap diff from master - unit tests

peak heap memory consumption: 27.68K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0596         -0.0597           248           233           247           233
BM_sinsp_split_median                                          -0.0607         -0.0609           248           232           247           232
BM_sinsp_split_stddev                                          -0.2903         -0.3339             1             1             1             1
BM_sinsp_split_cv                                              -0.2453         -0.2917             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0278         -0.0280            70            68            70            68
BM_sinsp_concatenate_paths_relative_path_median                -0.0250         -0.0251            70            68            69            68
BM_sinsp_concatenate_paths_relative_path_stddev                -0.2470         -0.2410             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    -0.2255         -0.2191             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0503         -0.0503            44            42            44            42
BM_sinsp_concatenate_paths_empty_path_median                   -0.0407         -0.0407            44            42            44            42
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.9586         -0.9607             1             0             1             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.9564         -0.9586             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0289         -0.0290            71            69            71            69
BM_sinsp_concatenate_paths_absolute_path_median                -0.0442         -0.0443            71            68            71            68
BM_sinsp_concatenate_paths_absolute_path_stddev               +11.5950        +11.9797             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                   +11.9705        +12.3667             0             0             0             0

@ekoops
ci: add install-bpftool composite action
26da9bf 
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops force-pushed the ekoops/ci-install-bpftool branch from e0af3fe to 26da9bf Compare December 11, 2025 13:14
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.56%. Comparing base (5baecd8) to head (26da9bf).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2748   +/-   ##
=======================================
  Coverage   74.56%   74.56%           
=======================================
  Files         292      292           
  Lines       29998    29998           
  Branches     4651     4651           
=======================================
  Hits        22367    22367           
  Misses       7631     7631
Flag Coverage Δ
libsinsp 74.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

irozzo-1A
irozzo-1A approved these changes Dec 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@irozzo-1A irozzo-1A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana poiana added the lgtm label Dec 11, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Dec 11, 2025
@poiana poiana merged commit f3c16cc into falcosecurity:master Dec 11, 2025
47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Dec 11, 2025
@ekoops ekoops deleted the ekoops/ci-install-bpftool branch December 11, 2025 16:12
@BrewTestBot BrewTestBot mentioned this pull request Dec 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnosek gnosek gnosek approved these changes

@irozzo-1A irozzo-1A irozzo-1A approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@terror96 terror96 Awaiting requested review from terror96

Assignees

@gnosek gnosek

@irozzo-1A irozzo-1A

Labels

approved area/CI dco-signoff: yes kind/design lgtm release-note-none size/M

Projects

Falco Roadmap
Status: Done

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ekoops @poiana @gnosek @irozzo-1A