Skip to content

clean(libsinsp): use the correct union member in extract_key<int64_t>#2745

Merged
poiana merged 1 commit intofalcosecurity:masterfrom
irozzo-1A:fix/extract_key_int64
Dec 10, 2025
Merged

clean(libsinsp): use the correct union member in extract_key<int64_t>#2745
poiana merged 1 commit intofalcosecurity:masterfrom
irozzo-1A:fix/extract_key_int64

Conversation

@irozzo-1A
Copy link
Copy Markdown
Contributor

@irozzo-1A irozzo-1A commented Dec 10, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

The template specialization of extract_key for int64_t uses the u64 union member instead of s64. This should not harm as the raw bit pattern is the same, but it's more clear and consistent.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@irozzo-1A
fix(libsinsp): use the correct union member in extract_key<int64_t>
77d0685 
The template specialization of extract_key for int64_t uses the u64
union member instead of s64. This should not harm as the raw bit pattern
is the same, but it's more clear and consistent.

Signed-off-by: irozzo-1A <iacopo@sysdig.com>
@poiana poiana added the size/XS label Dec 10, 2025
@poiana poiana added the lgtm label Dec 10, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Dec 10, 2025

LGTM label has been added.

DetailsGit tree hash: 9f46e7629781d0a5dc599d4b87ff57ceb392d285

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 10, 2025

Perf diff from master - unit tests

     4.32%    +13.68%  [.] sinsp_threadinfo::get_main_thread()
     4.62%    +10.20%  [.] std::__shared_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2>::__shared_ptr(std::__weak_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     3.46%     +9.96%  [.] sinsp_threadinfo::update_main_fdtable()
     3.62%     +8.30%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_add_ref_lock_nothrow()
     3.25%     +6.76%  [.] sinsp_threadinfo::get_fd_table()
     3.70%     +6.63%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::_M_get_use_count() const
     2.16%     +6.51%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count(std::__weak_count<(__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     6.19%     +5.81%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release()
    11.81%     -5.43%  [.] sinsp::next(sinsp_evt**)
     1.89%     +3.58%  [.] thread_group_info::get_first_thread() const

Heap diff from master - unit tests

peak heap memory consumption: 27.68K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0287         -0.0288           248           240           247           240
BM_sinsp_split_median                                          -0.0303         -0.0304           248           240           247           240
BM_sinsp_split_stddev                                          +0.1448         +0.1258             1             2             1             2
BM_sinsp_split_cv                                              +0.1786         +0.1592             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0830         +0.0828            70            76            70            76
BM_sinsp_concatenate_paths_relative_path_median                +0.0861         +0.0861            70            75            69            75
BM_sinsp_concatenate_paths_relative_path_stddev                -0.0110         -0.0149             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    -0.0868         -0.0903             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0526         -0.0526            44            42            44            42
BM_sinsp_concatenate_paths_empty_path_median                   -0.0396         -0.0396            44            42            44            42
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.1323         +0.1333             1             1             1             1
BM_sinsp_concatenate_paths_empty_path_cv                       +0.1951         +0.1963             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0483         +0.0482            71            75            71            75
BM_sinsp_concatenate_paths_absolute_path_median                +0.0489         +0.0491            71            75            71            75
BM_sinsp_concatenate_paths_absolute_path_stddev                +3.8283         +4.0072             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +3.6061         +3.7768             0             0             0             0

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.52%. Comparing base (85f2e38) to head (77d0685).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2745   +/-   ##
=======================================
  Coverage   74.52%   74.52%           
=======================================
  Files         291      291           
  Lines       30012    30012           
  Branches     4714     4714           
=======================================
  Hits        22366    22366           
  Misses       7646     7646
Flag Coverage Δ
libsinsp 74.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekoops ekoops added this to the 0.23.0 milestone Dec 10, 2025
ekoops
ekoops approved these changes Dec 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ekoops ekoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Dec 10, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8edf133 into falcosecurity:master Dec 10, 2025
47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Dec 10, 2025
@BrewTestBot BrewTestBot mentioned this pull request Dec 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnosek gnosek gnosek approved these changes

@ekoops ekoops ekoops approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@terror96 terror96 Awaiting requested review from terror96

Assignees

@gnosek gnosek

@ekoops ekoops

Labels

approved area/libsinsp dco-signoff: yes kind/cleanup lgtm release-note-none size/XS

Projects

Falco Roadmap
Status: Done

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@irozzo-1A @poiana @gnosek @ekoops