Skip to content

ci: replace ubuntu-22.04* with ubuntu-24.04*#2744

Merged
poiana merged 1 commit intomasterfrom
ekoops/bump-22.04-to-24.04
Dec 11, 2025
Merged

ci: replace ubuntu-22.04* with ubuntu-24.04*#2744
poiana merged 1 commit intomasterfrom
ekoops/bump-22.04-to-24.04

Conversation

@ekoops
Copy link
Copy Markdown
Contributor

@ekoops ekoops commented Dec 9, 2025 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR replaces ubuntu-22.04* runners with ubuntu-24.04* ones in majority of CI jobs.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/milestone 0.23.0

Does this PR introduce a user-facing change?:

NONE

@poiana poiana added this to the 0.23.0 milestone Dec 9, 2025
@poiana poiana added the approved label Dec 9, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.56%. Comparing base (85f2e38) to head (f861979).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2744      +/-   ##
==========================================
+ Coverage   74.52%   74.56%   +0.03%     
==========================================
  Files         291      292       +1     
  Lines       30012    29998      -14     
  Branches     4714     4651      -63     
==========================================
+ Hits        22366    22367       +1     
+ Misses       7646     7631      -15
Flag Coverage Δ
libsinsp 74.56% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2025 •
edited
Loading

Perf diff from master - unit tests

     4.39%    +12.80%  [.] std::__shared_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2>::__shared_ptr(std::__weak_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     3.52%    +11.12%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::_M_get_use_count() const
     4.11%     +9.70%  [.] sinsp_threadinfo::get_main_thread()
     3.44%     +8.17%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_add_ref_lock_nothrow()
     3.29%     +7.21%  [.] sinsp_threadinfo::update_main_fdtable()
     3.09%     +5.93%  [.] sinsp_threadinfo::get_fd_table()
     5.89%     +5.80%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release()
     2.05%     +5.80%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count(std::__weak_count<(__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
    11.23%     -5.33%  [.] sinsp::next(sinsp_evt**)
     1.80%     +4.27%  [.] thread_group_info::get_first_thread() const

Heap diff from master - unit tests

peak heap memory consumption: 27.68K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0177         -0.0177           248           243           247           243
BM_sinsp_split_median                                          -0.0173         -0.0173           248           243           247           243
BM_sinsp_split_stddev                                          +0.5966         +0.5804             1             2             1             2
BM_sinsp_split_cv                                              +0.6254         +0.6090             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0074         +0.0074            70            71            70            70
BM_sinsp_concatenate_paths_relative_path_median                +0.0164         +0.0164            70            71            69            71
BM_sinsp_concatenate_paths_relative_path_stddev                -0.0569         -0.0613             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    -0.0638         -0.0682             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0897         -0.0897            44            40            44            40
BM_sinsp_concatenate_paths_empty_path_median                   -0.0813         -0.0812            44            40            44            40
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.8551         -0.8595             1             0             1             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.8408         -0.8456             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0408         -0.0408            71            68            71            68
BM_sinsp_concatenate_paths_absolute_path_median                -0.0451         -0.0450            71            68            71            68
BM_sinsp_concatenate_paths_absolute_path_stddev                +4.6036         +4.7212             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +4.8417         +4.9643             0             0             0             0

@ekoops ekoops force-pushed the ekoops/bump-22.04-to-24.04 branch from 8243ac1 to 0c573dd Compare December 9, 2025 13:59
@poiana poiana added size/S and removed size/XS labels Dec 9, 2025
@ekoops ekoops force-pushed the ekoops/bump-22.04-to-24.04 branch 2 times, most recently from 3ef9dbf to d8ca39b Compare December 9, 2025 14:35
@poiana poiana added size/M and removed size/S labels Dec 10, 2025
@ekoops ekoops force-pushed the ekoops/bump-22.04-to-24.04 branch 6 times, most recently from 5f535f7 to 710b0f0 Compare December 10, 2025 11:55
@ekoops
ci: replace ubuntu-22.04* with ubuntu-24.04*
f861979 
Replace `ubuntu-22.04*` runners with `ubuntu-24.04*` ones in majority
of CI jobs.

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops force-pushed the ekoops/bump-22.04-to-24.04 branch from 710b0f0 to f861979 Compare December 10, 2025 16:27
@ekoops
Copy link
Copy Markdown
Contributor Author

ekoops commented Dec 10, 2025

Kernel testing CI failures are not related to this changes.

@ekoops ekoops changed the title wip: ci: replace ubuntu-22.04* with ubuntu-24.04* ci: replace ubuntu-22.04* with ubuntu-24.04* Dec 11, 2025
@poiana poiana added the lgtm label Dec 11, 2025
irozzo-1A
irozzo-1A approved these changes Dec 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@irozzo-1A irozzo-1A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Dec 11, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 5baecd8 into master Dec 11, 2025
97 of 115 checks passed
@poiana poiana deleted the ekoops/bump-22.04-to-24.04 branch December 11, 2025 09:26
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Dec 11, 2025
@BrewTestBot BrewTestBot mentioned this pull request Dec 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leogr leogr leogr approved these changes

@irozzo-1A irozzo-1A irozzo-1A approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@leogr leogr

@irozzo-1A irozzo-1A

Labels

approved area/CI dco-signoff: yes kind/feature New feature or request lgtm release-note-none size/M

Projects

Falco Roadmap
Status: Done

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ekoops @poiana @leogr @irozzo-1A