Skip to content

ci: replace ubuntu-latest with ubuntu-24.04#2743

Merged
poiana merged 1 commit intomasterfrom
ekoops/bump-ubuntu-version
Dec 9, 2025
Merged

ci: replace ubuntu-latest with ubuntu-24.04#2743
poiana merged 1 commit intomasterfrom
ekoops/bump-ubuntu-version

Conversation

@ekoops
Copy link
Copy Markdown
Contributor

@ekoops ekoops commented Dec 9, 2025 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR replaces ubuntu-latest with ubuntu-24.04.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/milestone 0.23.0

Does this PR introduce a user-facing change?:

NONE

@ekoops
ci: replace ubuntu-latest with ubuntu-24.04
e2e9709 
Replace latest with specific version to avoid surprises.

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@poiana poiana added this to the 0.23.0 milestone Dec 9, 2025
@poiana poiana requested review from hbrueckner and terror96 December 9, 2025 12:03
@poiana poiana added the approved label Dec 9, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2025 •
edited
Loading

Perf diff from master - unit tests

     4.80%    +13.26%  [.] std::__shared_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2>::__shared_ptr(std::__weak_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     3.84%    +10.55%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::_M_get_use_count() const
     4.49%     +9.30%  [.] sinsp_threadinfo::get_main_thread()
     3.77%     +9.04%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_add_ref_lock_nothrow()
     3.60%     +6.85%  [.] sinsp_threadinfo::update_main_fdtable()
     6.44%     +6.63%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release()
     3.38%     +6.27%  [.] sinsp_threadinfo::get_fd_table()
    12.28%     -5.35%  [.] sinsp::next(sinsp_evt**)
     2.25%     +5.04%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count(std::__weak_count<(__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     1.97%     +4.10%  [.] thread_group_info::get_first_thread() const

Heap diff from master - unit tests

peak heap memory consumption: 27.68K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0418         -0.0419           248           237           247           237
BM_sinsp_split_median                                          -0.0411         -0.0412           248           237           247           237
BM_sinsp_split_stddev                                          +0.1204         +0.0908             1             2             1             1
BM_sinsp_split_cv                                              +0.1692         +0.1385             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0057         -0.0059            70            70            70            70
BM_sinsp_concatenate_paths_relative_path_median                -0.0065         -0.0063            70            69            69            69
BM_sinsp_concatenate_paths_relative_path_stddev                +1.5007         +1.4985             1             2             1             2
BM_sinsp_concatenate_paths_relative_path_cv                    +1.5150         +1.5134             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0067         -0.0066            44            44            44            44
BM_sinsp_concatenate_paths_empty_path_median                   +0.0016         +0.0016            44            44            44            44
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.5900         -0.5916             1             0             1             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.5872         -0.5889             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0334         -0.0334            71            69            71            69
BM_sinsp_concatenate_paths_absolute_path_median                -0.0363         -0.0364            71            69            71            69
BM_sinsp_concatenate_paths_absolute_path_stddev                +1.7369         +1.8279             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    +1.8316         +1.9258             0             0             0             0

@ekoops ekoops force-pushed the ekoops/bump-ubuntu-version branch from 7d0448e to e2e9709 Compare December 9, 2025 13:06
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.52%. Comparing base (0d61d53) to head (e2e9709).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2743   +/-   ##
=======================================
  Coverage   74.52%   74.52%           
=======================================
  Files         291      291           
  Lines       30012    30012           
  Branches     4714     4714           
=======================================
  Hits        22366    22366           
  Misses       7646     7646
Flag Coverage Δ
libsinsp 74.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

irozzo-1A
irozzo-1A approved these changes Dec 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@irozzo-1A irozzo-1A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana poiana added the lgtm label Dec 9, 2025
@ekoops ekoops changed the title wip: ci: replace ubuntu-latest with ubuntu-24.04 ci: replace ubuntu-latest with ubuntu-24.04 Dec 9, 2025
deepskyblue86
deepskyblue86 approved these changes Dec 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@deepskyblue86 deepskyblue86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Dec 9, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Dec 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepskyblue86, ekoops, irozzo-1A

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [deepskyblue86,ekoops]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 85f2e38 into master Dec 9, 2025
64 of 90 checks passed
@poiana poiana deleted the ekoops/bump-ubuntu-version branch December 9, 2025 13:28
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Dec 9, 2025
@BrewTestBot BrewTestBot mentioned this pull request Dec 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepskyblue86 deepskyblue86 deepskyblue86 approved these changes

@irozzo-1A irozzo-1A irozzo-1A approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@terror96 terror96 Awaiting requested review from terror96

Assignees

@deepskyblue86 deepskyblue86

@irozzo-1A irozzo-1A

Labels

approved area/CI dco-signoff: yes kind/feature New feature or request lgtm release-note-none size/M

Projects

Falco Roadmap
Status: Done

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ekoops @poiana @deepskyblue86 @irozzo-1A