Skip to content

ci(perf.yml): use python venv to run gbench result comparison#2738

Merged
poiana merged 2 commits intofalcosecurity:masterfrom
ekoops:ekoops/use-venv-perf-ci
Dec 5, 2025
Merged

ci(perf.yml): use python venv to run gbench result comparison#2738
poiana merged 2 commits intofalcosecurity:masterfrom
ekoops:ekoops/use-venv-perf-ci

Conversation

@ekoops
Copy link
Copy Markdown
Contributor

@ekoops ekoops commented Dec 5, 2025 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR fixes the issue in https://github.com/falcosecurity/libs/actions/runs/19959292467/job/57236907247 by running gbench result comparison in a separate python virtual environment, and bumping the gbench version to a version newer than 1.9.4 (not released yet, but this is the only way to avoid dependency issues with python 3.12).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/milestone 0.23.0

Does this PR introduce a user-facing change?:

NONE

@poiana poiana added this to the 0.23.0 milestone Dec 5, 2025
@poiana poiana requested review from hbrueckner and terror96 December 5, 2025 11:37
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.02%. Comparing base (bcc11cc) to head (0a11138).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2738   +/-   ##
=======================================
  Coverage   77.02%   77.02%           
=======================================
  Files         296      296           
  Lines       30818    30818           
  Branches     4670     4670           
=======================================
  Hits        23738    23738           
  Misses       7080     7080
Flag Coverage Δ
libsinsp 77.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekoops ekoops force-pushed the ekoops/use-venv-perf-ci branch from b679615 to fd5e84c Compare December 5, 2025 12:21
@ekoops ekoops changed the title ci(perf.yml): use python venv to run gbench ci(perf.yml): use python venv to run gbench result comparison Dec 5, 2025
@ekoops ekoops force-pushed the ekoops/use-venv-perf-ci branch from 235b3ef to 12c3741 Compare December 5, 2025 13:03
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 5, 2025 •
edited
Loading

Perf diff from master - unit tests

     1.69%     +1.14%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_add_ref_lock_nothrow()
     1.94%     -0.73%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::_M_get_use_count() const
     1.48%     +0.28%  [.] sinsp_threadinfo::get_fd_table()
     5.42%     -0.28%  [.] sinsp::next(sinsp_evt**)
     3.41%     -0.27%  [.] next_event_from_file
     0.43%     +0.27%  [.] sinsp_parser::parse_context_switch(sinsp_evt&)
     2.30%     -0.24%  [.] std::__shared_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2>::__shared_ptr(std::__weak_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     1.43%     -0.20%  [.] sinsp_parser::process_event(sinsp_evt&, sinsp_parser_verdict&)
     2.03%     -0.20%  [.] sinsp_threadinfo::get_main_thread()
     0.73%     +0.20%  [.] sinsp_evt_param::used_legacy_null_encoding() const

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0234         +0.0233           232           237           232           237
BM_sinsp_split_median                                          +0.0276         +0.0274           231           237           231           237
BM_sinsp_split_stddev                                          -0.7670         -0.7753             3             1             3             1
BM_sinsp_split_cv                                              -0.7724         -0.7804             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0471         +0.0472            69            72            69            72
BM_sinsp_concatenate_paths_relative_path_median                +0.0511         +0.0511            69            73            69            73
BM_sinsp_concatenate_paths_relative_path_stddev                +0.1128         +0.1131             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    +0.0627         +0.0629             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0250         +0.0251            44            45            44            45
BM_sinsp_concatenate_paths_empty_path_median                   +0.0262         +0.0265            43            45            43            45
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.7274         -0.7267             2             1             2             1
BM_sinsp_concatenate_paths_empty_path_cv                       -0.7340         -0.7334             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0121         -0.0120            69            68            69            68
BM_sinsp_concatenate_paths_absolute_path_median                +0.0000         -0.0000            68            68            68            68
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.3304         -0.3288             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.3223         -0.3206             0             0             0             0

ekoops added 2 commits December 5, 2025 14:25
@ekoops
ci(perf.yml): bump google benchmark version to newer version
d8ee1bf 
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops
ci(perf.yml): use python venv to run gbench result comparison
0a11138 
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops force-pushed the ekoops/use-venv-perf-ci branch from 12c3741 to 0a11138 Compare December 5, 2025 13:26
@poiana poiana added the lgtm label Dec 5, 2025
@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Dec 5, 2025
@poiana poiana merged commit 69417c3 into falcosecurity:master Dec 5, 2025
47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Dec 5, 2025
@ekoops ekoops deleted the ekoops/use-venv-perf-ci branch December 5, 2025 13:58
@BrewTestBot BrewTestBot mentioned this pull request Dec 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnosek gnosek gnosek approved these changes

@leogr leogr leogr approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@terror96 terror96 Awaiting requested review from terror96

Assignees

@gnosek gnosek

@leogr leogr

Labels

approved area/CI dco-signoff: yes kind/bug Something isn't working lgtm release-note-none size/XS

Projects

Falco Roadmap
Status: Done

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ekoops @poiana @gnosek @leogr