Skip to content

fix(userspace/libscap/engine/savefile): fix converter debug log lines#2737

Merged
poiana merged 1 commit intofalcosecurity:masterfrom
ekoops:ekoops/improve-scap-converter-debugging
Dec 5, 2025
Merged

fix(userspace/libscap/engine/savefile): fix converter debug log lines#2737
poiana merged 1 commit intofalcosecurity:masterfrom
ekoops:ekoops/improve-scap-converter-debugging

Conversation

@ekoops
Copy link
Copy Markdown
Contributor

@ekoops ekoops commented Dec 5, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR fixes converter debug log lines and contextually improve them.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/milestone 0.23.0

Does this PR introduce a user-facing change?:

NONE

Fix converter debug log lines and contextually improve them.

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Dec 5, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.02%. Comparing base (e65bb86) to head (701472d).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2737   +/-   ##
=======================================
  Coverage   77.02%   77.02%           
=======================================
  Files         296      296           
  Lines       30818    30818           
  Branches     4670     4670           
=======================================
  Hits        23738    23738           
  Misses       7080     7080           
Flag Coverage Δ
libsinsp 77.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@poiana poiana added the lgtm label Dec 5, 2025
@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Dec 5, 2025
@poiana poiana merged commit bcc11cc into falcosecurity:master Dec 5, 2025
46 of 47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Dec 5, 2025
@ekoops ekoops deleted the ekoops/improve-scap-converter-debugging branch December 5, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants