Skip to content

chore(sinsp): clean-up syscall latency related code#2730

Merged
poiana merged 1 commit intofalcosecurity:masterfrom
irozzo-1A:clean-up-latency-handling
Dec 3, 2025
Merged

chore(sinsp): clean-up syscall latency related code#2730
poiana merged 1 commit intofalcosecurity:masterfrom
irozzo-1A:clean-up-latency-handling

Conversation

@irozzo-1A
Copy link
Copy Markdown
Contributor

@irozzo-1A irozzo-1A commented Nov 28, 2025

Remove the code related to the computation of the latency between enter and exit syscall events, because we are no longer processing enter events.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@irozzo-1A
chore(sinsp): clean-up syscall latency related code
f74878b 
Remove the code related to the computation of the latency between enter and
exit syscall events, because we are no longer processing enter events.

Signed-off-by: irozzo-1A <iacopo@sysdig.com>
@poiana poiana added the size/L label Nov 28, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 28, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.02%. Comparing base (a6638ac) to head (f74878b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
userspace/libsinsp/sinsp_filtercheck_event.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2730      +/-   ##
==========================================
+ Coverage   76.90%   77.02%   +0.11%     
==========================================
  Files         296      296              
  Lines       30877    30818      -59     
  Branches     4693     4670      -23     
==========================================
- Hits        23747    23738       -9     
+ Misses       7130     7080      -50
Flag Coverage Δ
libsinsp 77.02% <0.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@terror96
Copy link
Copy Markdown
Contributor

terror96 commented Dec 1, 2025

Hello @irozzo-1A, is there something still missing from this PR i.e. why the draft status? Just wondering should I wait with the lgtm tag...

@irozzo-1A irozzo-1A marked this pull request as ready for review December 1, 2025 08:45
@irozzo-1A
Copy link
Copy Markdown
Contributor Author

irozzo-1A commented Dec 1, 2025

Hello @irozzo-1A, is there something still missing from this PR i.e. why the draft status? Just wondering should I wait with the lgtm tag...

Hey @terror96 ,I was checking if there is anything else I could get rid of, but I'm good to start with this.

terror96
terror96 approved these changes Dec 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@terror96 terror96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana poiana added the lgtm label Dec 2, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Dec 2, 2025

LGTM label has been added.

DetailsGit tree hash: 25fe0730a911c110d9fff82e56920a012a3a0ad5

ekoops
ekoops approved these changes Dec 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ekoops ekoops left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/milestone 0.23.0
/approve

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Dec 3, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Dec 3, 2025

@ekoops: The provided milestone is not valid for this repository. Milestones in this repository: [0.22.2, 0.23.0, TBD, next-driver]

Use /milestone clear to clear the milestone.

Details

In response to this:

/milestone 0.32.0
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@poiana
Copy link
Copy Markdown
Contributor

poiana commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A, terror96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Dec 3, 2025
@ekoops
Copy link
Copy Markdown
Contributor

ekoops commented Dec 3, 2025

/milestone 0.23.0

@poiana poiana added this to the 0.23.0 milestone Dec 3, 2025
@poiana poiana merged commit b24461e into falcosecurity:master Dec 3, 2025
45 of 47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Dec 3, 2025
@BrewTestBot BrewTestBot mentioned this pull request Dec 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terror96 terror96 terror96 approved these changes

@ekoops ekoops ekoops approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@terror96 terror96

@ekoops ekoops

Labels

approved area/libsinsp dco-signoff: yes kind/cleanup lgtm release-note-none size/L

Projects

Falco Roadmap
Archived in project

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@irozzo-1A @terror96 @poiana @ekoops