Skip to content

cleanup(userspace): Fix various Visual C++ warnings#2729

Merged
poiana merged 1 commit intofalcosecurity:masterfrom
geraldcombs:visual-cpp-warnings
Nov 26, 2025
Merged

cleanup(userspace): Fix various Visual C++ warnings#2729
poiana merged 1 commit intofalcosecurity:masterfrom
geraldcombs:visual-cpp-warnings

Conversation

@geraldcombs
Copy link
Copy Markdown
Contributor

@geraldcombs geraldcombs commented Nov 25, 2025

sinsp_evt_param's ctor takes uint32_ts, so add a cast to sinsp_evt::load_params() to match. [[gnu::cold]] is limited to gcc and clang, so wrap it in an #if guard. Fix various printf and scanf specifiers.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This makes the Visual C++ build output much less noisy.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 25, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.90%. Comparing base (34c404a) to head (8082bfa).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
userspace/libsinsp/examples/test.cpp 0.00% 3 Missing ⚠️
userspace/libsinsp/test/test_utils.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2729   +/-   ##
=======================================
  Coverage   76.90%   76.90%           
=======================================
  Files         296      296           
  Lines       30875    30877    +2     
  Branches     4693     4693           
=======================================
+ Hits        23745    23747    +2     
  Misses       7130     7130
Flag Coverage Δ
libsinsp 76.90% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@geraldcombs
cleanup(userspace): Fix various Visual C++ warnings
8082bfa 
sinsp_evt_param's ctor takes uint32_ts, so add a cast to
sinsp_evt::load_params() to match. [[gnu::cold]] is limited to gcc
and clang, so wrap it in an #if guard. Fix various printf and scanf
specifiers.

Signed-off-by: Gerald Combs <gerald@wireshark.org>
terror96
terror96 approved these changes Nov 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@terror96 terror96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana poiana added the lgtm label Nov 26, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Nov 26, 2025

LGTM label has been added.

DetailsGit tree hash: f510eb291f6228d553476681313fa10e40989691

ekoops
ekoops approved these changes Nov 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ekoops ekoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Nov 26, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, geraldcombs, terror96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ekoops ekoops added this to the 0.23.0 milestone Nov 26, 2025
@poiana poiana merged commit a6638ac into falcosecurity:master Nov 26, 2025
45 of 47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Nov 26, 2025
@BrewTestBot BrewTestBot mentioned this pull request Dec 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terror96 terror96 terror96 approved these changes

@ekoops ekoops ekoops approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@terror96 terror96

@ekoops ekoops

Labels

approved area/libscap area/libsinsp area/tests dco-signoff: yes kind/cleanup lgtm release-note-none size/S

Projects

Falco Roadmap
Archived in project

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@geraldcombs @poiana @terror96 @ekoops