Skip to content

ci(drivers_ci): move drivers build for s390x to dedicated runner#2725

Merged
poiana merged 1 commit intomasterfrom
ekoops/switch-to-s390x-runner
Nov 25, 2025
Merged

ci(drivers_ci): move drivers build for s390x to dedicated runner#2725
poiana merged 1 commit intomasterfrom
ekoops/switch-to-s390x-runner

Conversation

@ekoops
Copy link
Copy Markdown
Contributor

@ekoops ekoops commented Nov 24, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This repo has now access to s390x runners provided by https://github.com/IBM/actionspz. This PR leverages these new runners to build drivers and drivers tests for the s390x architecture, replacing the old mechanism leveraging emulation. Please notice that this drastically reduce the job execution time: from ~1h to ~3m)!
The access to these runners were provided after filing IBM/actionspz#3 . It is restricted only to authenticated repos, so unfortunately we will not run the job anymore on forked repos. I also tried to run the built drivers tests on the job, but I hit the problem described here: IBM/actionspz#3 (comment). For this reason, for the moment, we still don't run any driver test for the s390x architecture.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/milestone next-driver

Does this PR introduce a user-facing change?:

NONE

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.90%. Comparing base (e231639) to head (7290ef6).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2725   +/-   ##
=======================================
  Coverage   76.90%   76.90%           
=======================================
  Files         296      296           
  Lines       30875    30875           
  Branches     4693     4693           
=======================================
  Hits        23745    23745           
  Misses       7130     7130           
Flag Coverage Δ
libsinsp 76.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekoops ekoops force-pushed the ekoops/switch-to-s390x-runner branch from 01bccea to 6f91557 Compare November 24, 2025 18:02
@ekoops ekoops mentioned this pull request Nov 24, 2025
2 tasks
@ekoops ekoops force-pushed the ekoops/switch-to-s390x-runner branch 6 times, most recently from 2f2cfeb to dd5d046 Compare November 25, 2025 13:31
@poiana poiana added size/M and removed size/L labels Nov 25, 2025
@ekoops ekoops force-pushed the ekoops/switch-to-s390x-runner branch from dd5d046 to e87c638 Compare November 25, 2025 13:33
@ekoops ekoops changed the title wip: ci: enable drivers test on s390x ci(drivers_ci): move drivers build on s390x to dedicated runner Nov 25, 2025
@ekoops ekoops force-pushed the ekoops/switch-to-s390x-runner branch 2 times, most recently from df48dd4 to eca4fd8 Compare November 25, 2025 14:14
@ekoops ekoops marked this pull request as ready for review November 25, 2025 14:14
@poiana poiana requested a review from irozzo-1A November 25, 2025 14:14
@ekoops
Copy link
Copy Markdown
Contributor Author

ekoops commented Nov 25, 2025

/milestone next-driver

@poiana poiana added this to the next-driver milestone Nov 25, 2025
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops changed the title ci(drivers_ci): move drivers build on s390x to dedicated runner ci(drivers_ci): move drivers build for s390x to dedicated runner Nov 25, 2025
@ekoops ekoops force-pushed the ekoops/switch-to-s390x-runner branch from eca4fd8 to 7290ef6 Compare November 25, 2025 14:17
Copy link
Copy Markdown
Contributor

@irozzo-1A irozzo-1A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Nov 25, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 71366e3 into master Nov 25, 2025
46 of 47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Nov 25, 2025
@poiana poiana deleted the ekoops/switch-to-s390x-runner branch November 25, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants