feat(driver)!: bump drivers' minimum required kernel version to 3.10#2722
feat(driver)!: bump drivers' minimum required kernel version to 3.10#2722
3.10#2722Conversation
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
|
Please double check driver/SCHEMA_VERSION file. See versioning. /hold |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2722 +/- ##
=======================================
Coverage 76.90% 76.90%
=======================================
Files 296 296
Lines 30875 30875
Branches 4693 4693
=======================================
Hits 23745 23745
Misses 7130 7130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR LGTM! Just a side note; we should make sure to update driverkit minimum kmod version, and kernel crawler too (to avoid processing unsupported kernel versions, if any is still present in any repo). Or we can keep them as they are now, allowing one to attempt the build of kmod against unsupported kernel releases(falling the build of course). |
Agree! I'll take care of updating the minimum version for driverkit and the kernel crawler |
False positive. No need to update |
|
/remove-hold |
irozzo-1A
left a comment
There was a problem hiding this comment.
/lgtm
Do you have a PR to update the docs already?
deepskyblue86
left a comment
There was a problem hiding this comment.
Nice cleanup (finally)!
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepskyblue86, ekoops, irozzo-1A The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ekoops perhaps it would be even better to avoid touching kernel-crawler (whose output should be as agnostic as possible) and let |
|
I forgot to mention that this bump is a pre-requisite for an upcoming fix related to #2709 . |
I'll take a look at dbg-go. I didn't know about it. Thank you 😄 |
Sorry I didn't see your message. Not yet, I have in my TODO list, besides looking at dbg-go to stop generating configurations for unsupported kernel releases. |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR bumps the drivers' minimum required kernel version to
3.10. In practice, this only affects the kmod driver. The kmod driver will not compile anymore on version older than3.10, whatever is the architecture. This choice is motivated by the fact that even linux3.10is a 12 years old kernel, and its support ended on 2017: maintaining support for older kernel is a maintenance burden and limits progresses.Notice that I added a build time check in the kernel module aborting the compilation on kernel <
3.10. This is redudant, as it is already checked in thedriver/CMakeLists.txt, but just to be sure, in case someone tries to compile it using other mechanisms.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/milestone next-driver
Does this PR introduce a user-facing change?: