fix(userspace/libpman): fix bpf helper probe error handling#2720
Merged
poiana merged 1 commit intofalcosecurity:masterfrom Nov 20, 2025
Merged
Conversation
`libbpf_probe_bpf_helper` returns 1 if the given combination of program type and helper is supported, 0 or a negative number otherwise. Account for the negative number case by explicitely checking that the returned value is different from 1. See https://docs.ebpf.io/ebpf-library/libbpf/userspace/libbpf_probe_bpf_helper/. Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2720 +/- ##
=======================================
Coverage 76.90% 76.90%
=======================================
Files 296 296
Lines 30875 30875
Branches 4693 4693
=======================================
Hits 23745 23745
Misses 7130 7130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, irozzo-1A The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
leogr
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libpman
Does this PR require a change in the driver versions?
What this PR does / why we need it:
libbpf_probe_bpf_helperreturns 1 if the given combination of program type and helper is supported, 0 or a negative number otherwise. This PR accounts for the negative number case by explicitely checking that the returned value is different from 1.See https://docs.ebpf.io/ebpf-library/libbpf/userspace/libbpf_probe_bpf_helper/.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/milestone 0.23.0
Does this PR introduce a user-facing change?: