Skip to content

fix: clone CLONE_CHILD_IN_PIDNS not rendered#2717

Merged
poiana merged 1 commit intofalcosecurity:masterfrom
deepskyblue86:CLONE_CHILD_IN_PIDNS
Nov 19, 2025
Merged

fix: clone CLONE_CHILD_IN_PIDNS not rendered#2717
poiana merged 1 commit intofalcosecurity:masterfrom
deepskyblue86:CLONE_CHILD_IN_PIDNS

Conversation

@deepskyblue86
Copy link
Copy Markdown
Member

@deepskyblue86 deepskyblue86 commented Nov 15, 2025

What type of PR is this?
/kind bug

Any specific area of the project related to this PR?

/area libsinsp

What this PR does / why we need it:
PPM_CL_CHILD_IN_PIDNS (introduced in 3b7a794f8) doesn't get rendered:

{
  "evt.dir": "<",
  "evt.info": "res=0 exe=java args=<redacted> tid=104304(Attach API init) pid=104236(java) ptid=104181(containerd-shim) cwd=<NA> fdlimit=1048576 pgft_maj=0 pgft_min=0 vm_size=16082388 vm_rss=114176 vm_swap=0 comm=Attach API init cgroups=<redacted> flags=536870912 uid=1001 gid=0 vtid=60 vpid=1(systemd) pidns_init_start_ts=3197917212257280",
  "evt.num": 89846,
  "evt.type": "clone3",
  "proc.name": "Attach API init",
  "proc.pid": 104236,
  "thread.tid": 104304
}

Notice flags=536870912 being #define PPM_CL_CHILD_IN_PIDNS (1<<29)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Angelo Puglisi <angelopuglisi86@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.90%. Comparing base (a8fb3d2) to head (4b86cdf).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2717   +/-   ##
=======================================
  Coverage   76.90%   76.90%           
=======================================
  Files         296      296           
  Lines       30875    30875           
  Branches     4693     4693           
=======================================
  Hits        23745    23745           
  Misses       7130     7130           
Flag Coverage Δ
libsinsp 76.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@ekoops ekoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Copy Markdown
Contributor

poiana commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepskyblue86, ekoops

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Copy Markdown
Contributor

poiana commented Nov 17, 2025

LGTM label has been added.

DetailsGit tree hash: a43ad0f52ca634c4f1f69ceb4daa32e29f3c8412

@ekoops ekoops modified the milestones: 0.23.0, next-driver Nov 17, 2025
@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Nov 19, 2025
@poiana poiana merged commit bb45c63 into falcosecurity:master Nov 19, 2025
54 of 55 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants