Skip to content

chore(userspace/plugin): drop RTLD_DEEPBIND but keep RTLD_LOCAL | LD_NOW for loading plugins#2698

Merged
poiana merged 1 commit intomasterfrom
revert/TRLD_DEEPBIND
Oct 20, 2025
Merged

chore(userspace/plugin): drop RTLD_DEEPBIND but keep RTLD_LOCAL | LD_NOW for loading plugins#2698
poiana merged 1 commit intomasterfrom
revert/TRLD_DEEPBIND

Conversation

@leogr
Copy link
Copy Markdown
Member

@leogr leogr commented Oct 20, 2025 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Partially revert 657e1d7

Which issue(s) this PR fixes:

See falcosecurity/falco#3704

Special notes for your reviewer:

/milestone 0.22.1

Does this PR introduce a user-facing change?:

fix: avoid libc incompatibilities by removing `RTLD_DEEPBIND` when loading plugins

@leogr @irozzo-1A @ekoops
chore(userspace/plugin): drop RTLD_DEEPBIND but keep `RTLD_LOCAL | RT…
34b3d5e 
…LD_NOW` for loading plugins

Partially revert 657e1d7

Co-authored-by: Iacopo Rozzo <iacopo@sysdig.com>
Co-authored-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@poiana poiana added this to the 0.22.1 milestone Oct 20, 2025
@poiana poiana requested review from irozzo-1A and terror96 October 20, 2025 09:47
@leogr leogr mentioned this pull request Oct 20, 2025
Closed
89 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.62%. Comparing base (f2c2ba2) to head (34b3d5e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2698   +/-   ##
=======================================
  Coverage   77.62%   77.62%           
=======================================
  Files         294      294           
  Lines       31951    31951           
  Branches     4716     4716           
=======================================
  Hits        24802    24802           
  Misses       7149     7149
Flag Coverage Δ
libsinsp 77.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

irozzo-1A
irozzo-1A approved these changes Oct 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@irozzo-1A irozzo-1A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana poiana added the lgtm label Oct 20, 2025
ekoops
ekoops approved these changes Oct 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ekoops ekoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/falcosecurity/libs/actions/runs/18648310896/job/53161579583?pr=2698 and similar CI errors don't seem related to this PR. Look like transient errors, so I'm gonna approve this.

/approve

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Oct 20, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3943920 into master Oct 20, 2025
59 of 66 checks passed
@poiana poiana deleted the revert/TRLD_DEEPBIND branch October 20, 2025 10:16
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Oct 20, 2025
@ekoops ekoops mentioned this pull request Oct 20, 2025
Merged
@osalbahr osalbahr mentioned this pull request Oct 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irozzo-1A irozzo-1A irozzo-1A approved these changes

@ekoops ekoops ekoops approved these changes

@terror96 terror96 Awaiting requested review from terror96

Assignees

@irozzo-1A irozzo-1A

@ekoops ekoops

Labels

approved area/libsinsp dco-signoff: yes kind/bug Something isn't working lgtm release-note size/S

Projects

Falco Roadmap
Archived in project

Milestone

0.22.1

Development

Successfully merging this pull request may close these issues.

4 participants

@leogr @poiana @irozzo-1A @ekoops