Skip to content

feat(driver/modern_bpf)!: remove forgotten pwrite64_e prog#2626

Merged
poiana merged 1 commit intofalcosecurity:masterfrom
ekoops:ekoops/drop-pwrite64-e
Sep 11, 2025
Merged

feat(driver/modern_bpf)!: remove forgotten pwrite64_e prog#2626
poiana merged 1 commit intofalcosecurity:masterfrom
ekoops:ekoops/drop-pwrite64-e

Conversation

@ekoops
Copy link
Copy Markdown
Contributor

@ekoops ekoops commented Sep 11, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of #2588. It completes the partial drop of pwrite64 enter event generation support performed in #2614.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Not bumping the driver schema version is currently a practice we are following as we will bump it in a single shot once we are done with the #2068 proposal.

/milestone 0.22.0

Does this PR introduce a user-facing change?:

feat(driver/modern_bpf)!: remove forgotten `pwrite64_e` prog

BREAKING CHANGE: stop generating `pwrite64` enter gen in modern probe

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.25%. Comparing base (54265ea) to head (61de275).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2626   +/-   ##
=======================================
  Coverage   78.25%   78.25%           
=======================================
  Files         294      294           
  Lines       31826    31826           
  Branches     4667     4667           
=======================================
  Hits        24905    24905           
  Misses       6921     6921           
Flag Coverage Δ
libsinsp 78.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@irozzo-1A irozzo-1A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Sep 11, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Sep 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit cdb3d6d into falcosecurity:master Sep 11, 2025
60 of 63 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Sep 11, 2025
@ekoops ekoops deleted the ekoops/drop-pwrite64-e branch September 11, 2025 12:21
@leogr leogr modified the milestones: 0.22.0, 9.0.0+driver Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants