Skip to content

chore(ci): reduce zig download flakiness#2597

Merged
poiana merged 1 commit intofalcosecurity:masterfrom
irozzo-1A:fix/zig-download-flakiness
Sep 1, 2025
Merged

chore(ci): reduce zig download flakiness#2597
poiana merged 1 commit intofalcosecurity:masterfrom
irozzo-1A:fix/zig-download-flakiness

Conversation

@irozzo-1A
Copy link
Copy Markdown
Contributor

@irozzo-1A irozzo-1A commented Sep 1, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Add retries to the command used to download the Zig toolchain tarball. It recently started flaking, indicating the connection is being reset by the server.

curl: (56) OpenSSL SSL_read: SSL_ERROR_SYSCALL, errno 104

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.17%. Comparing base (e9f4896) to head (eac9c75).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2597   +/-   ##
=======================================
  Coverage   78.17%   78.17%           
=======================================
  Files         298      298           
  Lines       32087    32087           
  Branches     4691     4691           
=======================================
  Hits        25083    25083           
  Misses       7004     7004           
Flag Coverage Δ
libsinsp 78.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add retries to the command used to download the Zig toolchain tarball.
It recently started flaking, indicating the connection is being reset by the
server.

```
curl: (56) OpenSSL SSL_read: SSL_ERROR_SYSCALL, errno 104
```

Signed-off-by: Iacopo Rozzo <iacopo@sysdig.com>
@irozzo-1A irozzo-1A force-pushed the fix/zig-download-flakiness branch from c314192 to eac9c75 Compare September 1, 2025 13:36
@irozzo-1A irozzo-1A marked this pull request as ready for review September 1, 2025 13:38
@poiana poiana requested a review from LucaGuerra September 1, 2025 13:38
@irozzo-1A irozzo-1A changed the title chore(ci): zig download flakiness attempted fix chore(ci): reduce zig download flakiness Sep 1, 2025
Copy link
Copy Markdown
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/milestone 0.22.0

@poiana poiana added this to the 0.22.0 milestone Sep 1, 2025
@poiana poiana added the lgtm label Sep 1, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Sep 1, 2025

LGTM label has been added.

DetailsGit tree hash: 5eb2848c6fc975049796c50f0ee47f73424db53a

Copy link
Copy Markdown
Contributor

@ekoops ekoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Sep 1, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Sep 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Sep 1, 2025
@poiana poiana merged commit 64af564 into falcosecurity:master Sep 1, 2025
44 of 47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants