Skip to content

test: fix tests on ppc64le#2470

Merged
poiana merged 4 commits intomasterfrom
ekoops/fix-test-drivers-ppc64le
Jun 11, 2025
Merged

test: fix tests on ppc64le#2470
poiana merged 4 commits intomasterfrom
ekoops/fix-test-drivers-ppc64le

Conversation

@ekoops
Copy link
Copy Markdown
Contributor

@ekoops ekoops commented Jun 11, 2025 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR:

  • removes any old libs clones in Drivers CI's test-drivers-ppc64le job just before cloning again libs and checking out the required branch: this enables the job to always operate on the updated branch
  • disables the bundled elf to avoid R_PPC64_NONE symbol redefinition
  • removes redundant zero initializer in aggregate initialization
  • fix domain parameter export by converting it to its corresponding scap representation before sending it (only for legacy bpf and kernel probes)
  • fix some minor errors in tests

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana poiana requested review from LucaGuerra and hbrueckner June 11, 2025 08:29
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 11, 2025

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

@ekoops
Copy link
Copy Markdown
Contributor Author

ekoops commented Jun 11, 2025

/milestone 0.22.0

@poiana poiana added this to the 0.22.0 milestone Jun 11, 2025
FedeDP
FedeDP reviewed Jun 11, 2025
View reviewed changes
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 11, 2025 •
edited
Loading

Perf diff from master - unit tests

     4.68%     -0.30%  [.] sinsp_thread_manager::find_thread
     0.91%     -0.28%  [.] sinsp_evt::get_syscall_return_value
     2.30%     +0.25%  [.] sinsp_thread_manager::get_thread_ref
     1.46%     -0.20%  [.] user_group_updater::user_group_updater
     0.66%     -0.19%  [.] scap_next
     6.74%     -0.19%  [.] sinsp::next
     0.94%     +0.14%  [.] sinsp_evt_filter::sinsp_evt_filter
     2.79%     -0.13%  [.] gzfile_read
     1.50%     -0.12%  [.] next
     5.32%     +0.12%  [.] sinsp_parser::reset

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0058         +0.0058           146           147           146           147
BM_sinsp_split_median                                          +0.0075         +0.0075           146           147           146           147
BM_sinsp_split_stddev                                          -0.3391         -0.3385             1             1             1             1
BM_sinsp_split_cv                                              -0.3430         -0.3423             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0033         +0.0033            57            58            57            58
BM_sinsp_concatenate_paths_relative_path_median                -0.0053         -0.0053            57            57            57            57
BM_sinsp_concatenate_paths_relative_path_stddev                +1.4980         +1.4977             0             1             0             1
BM_sinsp_concatenate_paths_relative_path_cv                    +1.4898         +1.4895             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0165         +0.0165            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0202         +0.0202            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.4524         -0.4528             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.4613         -0.4617             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0098         -0.0098            59            58            59            58
BM_sinsp_concatenate_paths_absolute_path_median                +0.0038         +0.0038            59            59            59            59
BM_sinsp_concatenate_paths_absolute_path_stddev                +3.4118         +3.4145             0             2             0             2
BM_sinsp_concatenate_paths_absolute_path_cv                    +3.4553         +3.4581             0             0             0             0

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.85%. Comparing base (42182ff) to head (dca0ebd).
Report is 7 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2470      +/-   ##
==========================================
+ Coverage   77.84%   77.85%   +0.01%     
==========================================
  Files         248      249       +1     
  Lines       31017    31038      +21     
  Branches     4661     4661              
==========================================
+ Hits        24144    24165      +21     
  Misses       6873     6873
Flag Coverage Δ
libsinsp 77.85% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekoops
ci: remove old libs clones and disable bundled libelf on ppc64 tests
dd6a23f 
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops force-pushed the ekoops/fix-test-drivers-ppc64le branch from 0e49481 to 8a25506 Compare June 11, 2025 08:39
@ekoops
refactor: remove redundant zero init in aggregate initialization
769f026 
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops force-pushed the ekoops/fix-test-drivers-ppc64le branch from 8a25506 to a00b65b Compare June 11, 2025 08:44
@poiana poiana added size/XL and removed size/XS labels Jun 11, 2025
@ekoops ekoops changed the title ci: remove old libs clones and disable bundled libelf on ppc64 tests ci: fix test-drivers-ppc64le Jun 11, 2025
@ekoops ekoops changed the title ci: fix test-drivers-ppc64le test: fix tests on ppc64le Jun 11, 2025
@ekoops ekoops mentioned this pull request Jun 11, 2025
Closed
@ekoops ekoops requested a review from FedeDP June 11, 2025 08:48
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 11, 2025 •
edited
Loading

X64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 ❌ 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

ARM64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

@ekoops ekoops force-pushed the ekoops/fix-test-drivers-ppc64le branch from a00b65b to 8b96d2f Compare June 11, 2025 09:57
@poiana poiana removed the size/XL label Jun 11, 2025
@ekoops ekoops force-pushed the ekoops/fix-test-drivers-ppc64le branch 7 times, most recently from 83a5014 to 1556dde Compare June 11, 2025 12:10
ekoops added 2 commits June 11, 2025 14:44
@ekoops
fix(driver): convert domain before sending it in socket and socketpair
0da3e9b 
Fix `domain` parameter exported value by converting it to its
corresponding scap representation in both legacy bpf and kernel
probes.

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops
fix(test/drivers): fix multiple driver tests
dca0ebd 
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops force-pushed the ekoops/fix-test-drivers-ppc64le branch from 1556dde to dca0ebd Compare June 11, 2025 12:45
@poiana poiana added the lgtm label Jun 11, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Jun 11, 2025

LGTM label has been added.

DetailsGit tree hash: 5fa24de80cf3e97ec2ea9e7c6f466dad3774bafa

FedeDP
FedeDP approved these changes Jun 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Jun 11, 2025
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Jun 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Copy Markdown
Contributor

FedeDP commented Jun 11, 2025

/unhold

@poiana poiana merged commit f9812eb into master Jun 11, 2025
57 of 58 checks passed
@poiana poiana deleted the ekoops/fix-test-drivers-ppc64le branch June 11, 2025 14:51
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Jun 11, 2025
@ekoops ekoops mentioned this pull request Jun 16, 2025
Merged
@ekoops ekoops mentioned this pull request Nov 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leogr leogr leogr approved these changes

@FedeDP FedeDP FedeDP approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@LucaGuerra LucaGuerra Awaiting requested review from LucaGuerra

Assignees

@leogr leogr

@FedeDP FedeDP

Labels

approved area/CI dco-signoff: yes kind/bug Something isn't working lgtm release-note-none size/XXL

Projects

Falco Roadmap
Archived in project

Milestone

0.22.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ekoops @poiana @FedeDP @leogr