Skip to content

[falcosidekick] replace curl image#969

Merged
poiana merged 1 commit intofalcosecurity:masterfrom
jfcoz:fix/sidekick_test_multiarch_support
Mar 17, 2026
Merged

[falcosidekick] replace curl image#969
poiana merged 1 commit intofalcosecurity:masterfrom
jfcoz:fix/sidekick_test_multiarch_support

Conversation

@jfcoz
Copy link
Copy Markdown
Contributor

@jfcoz jfcoz commented Mar 11, 2026

Replace old mono arch curl image by the official multi-arch image in sidekick test

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area falcosidekick-chart

What this PR does / why we need it:

Use the official and multi-arch curl image instead of an old mono-arch. test is currently failing on arm

Which issue(s) this PR fixes:

none

Special notes for your reviewer:

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana requested review from Issif and bencer March 11, 2026 22:34
@poiana poiana added the size/XS label Mar 11, 2026
@jfcoz jfcoz force-pushed the fix/sidekick_test_multiarch_support branch from 2459719 to 2110979 Compare March 11, 2026 22:39
Copy link
Copy Markdown
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Please note this PR needs to be rebased on top of the current master (see also my comment below)

🙏

Replace old mono arch curl image by the official multi-arch image in sidekick test

Signed-off-by: Julien Francoz <julien-github@francoz.net>
@jfcoz jfcoz force-pushed the fix/sidekick_test_multiarch_support branch from 2110979 to 79cbcde Compare March 16, 2026 20:41
@poiana poiana added size/S and removed size/XS labels Mar 16, 2026
Copy link
Copy Markdown
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@poiana
Copy link
Copy Markdown
Contributor

poiana commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jfcoz, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Copy Markdown
Contributor

poiana commented Mar 17, 2026

LGTM label has been added.

DetailsGit tree hash: 2c6263907eac1d5a1502ce268e45bfcfe7374aca

@poiana poiana merged commit 0da33a7 into falcosecurity:master Mar 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants