Skip to content

feat: Add support for GCP Workload Identity#952

Merged
poiana merged 1 commit intofalcosecurity:masterfrom
Mlaczkowski:add_wi_for_falcosidekick
Feb 27, 2026
Merged

feat: Add support for GCP Workload Identity#952
poiana merged 1 commit intofalcosecurity:masterfrom
Mlaczkowski:add_wi_for_falcosidekick

Conversation

@Mlaczkowski
Copy link
Copy Markdown
Contributor

@Mlaczkowski Mlaczkowski commented Jan 30, 2026

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falcosidekick-chart

/area falco-talon-chart

/area event-generator-chart

/area k8s-metacollector-chart

What this PR does / why we need it:
This PR introduces support for using GCP Workload Identity on Falcosidekick chart - https://docs.cloud.google.com/kubernetes-engine/docs/how-to/workload-identity

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added kind/feature New feature or request dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped area/falco-chart area/falcosidekick-chart labels Jan 30, 2026
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Jan 30, 2026

Welcome @Mlaczkowski! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana requested review from bencer and cpanato January 30, 2026 18:11
@poiana poiana added the size/S label Jan 30, 2026
leogr
leogr reviewed Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mlaczkowski

Thanks for this PR.

Can you remove the falco chart changes? These should be a separate PR after the falcosidekick chart is released.

Also, run make falcosidekick-docs to regenerate README.md instead of editing it manually.

Otherwise, SGMT.

Thank you 🙏

@leogr
Copy link
Copy Markdown
Member

leogr commented Feb 26, 2026

Hey @Mlaczkowski

427f919 must be signed off as well. Can you fix it, please? 🙏

@Mlaczkowski
feat: Add support for GCP Workload Identity
bc77cc3 
Signed-off-by: mlaczkowski <mateusz.laczkowski@gmail.com>
@Mlaczkowski Mlaczkowski force-pushed the add_wi_for_falcosidekick branch from 427f919 to bc77cc3 Compare February 26, 2026 13:04
@Mlaczkowski
Copy link
Copy Markdown
Contributor Author

Mlaczkowski commented Feb 26, 2026

Hi @leogr,

Sure, all commits are now signed.

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Feb 27, 2026
@poiana poiana added the lgtm label Feb 27, 2026
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Feb 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, Mlaczkowski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Copy Markdown
Contributor

poiana commented Feb 27, 2026

LGTM label has been added.

DetailsGit tree hash: bb0156fa0350edf767dd117ec4adc6ca180e6a07

@poiana poiana merged commit 383e869 into falcosecurity:master Feb 27, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leogr leogr leogr approved these changes

@bencer bencer Awaiting requested review from bencer

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@leogr leogr

Labels

approved area/falco-chart area/falcosidekick-chart dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped kind/feature New feature or request lgtm size/S

Projects

Falco Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mlaczkowski @poiana @leogr