Fix: Faker::Number.hexadecimal should include characters within the range of [0-9a-f]
#2942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because
Faker::Number.hexadecimalreturns characters within the range of [0-9a-e], when it should return characters within the range of [0-9a-f]. The method is not producing thefcharacter within the generated hexadecimal strings.Additional Information
The current implementation (above) includes
rand(15), which is not inclusive and only returns the range [0-14], when the implementation requires [0-15] in order to return thefcharacter. Adjusting the current implementation to returnrand(16).to_s(16)allows theFaker::Number.hexadecimalmethod to return strings within the full character range (including the letterf, which is equal to15.to_s(16)).Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]