Skip to content

Test default locale + and update README #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thdaraujo merged 1 commit into from
Jul 22, 2023
Merged

Test default locale + and update README #2802

thdaraujo merged 1 commit into from
Jul 22, 2023

Conversation

@stefannibrasil
Copy link
Contributor

@stefannibrasil stefannibrasil commented Jul 22, 2023

Follow up of #2734

co-authored by @thdaraujo

@sbs-cats @thdaraujo
Test default locale
af1e944 
and update README

Co-authored-by: Thiago Araujo <thd.araujo@gmail.com>
@stefannibrasil stefannibrasil linked an issue Jul 22, 2023 that may be closed by this pull request
Locale setting can be ignored #2563
Closed
@stefannibrasil stefannibrasil requested a review from thdaraujo July 22, 2023 00:37
thdaraujo
thdaraujo approved these changes Jul 22, 2023
View reviewed changes
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thdaraujo thdaraujo merged commit 0839df2 into faker-ruby:main Jul 22, 2023
@stefannibrasil stefannibrasil deleted the fixes-locale-setting branch July 22, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thdaraujo thdaraujo thdaraujo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Locale setting can be ignored

3 participants

@stefannibrasil @thdaraujo @sbs-cats