-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Description
Describe the bug
While looking at lib/locales/en/address.yml, I noticed some small issues as follows:
Some country names are not up to date:
-
Cape Verde was renamed "Cabo Verde" in 2013 (https://www.un.org/en/about-us/member-states/cabo-verde)
-
Swaziland was renamed "Eswatini" in 2018 (see UN website: https://www.un.org/en/about-us/member-states/eswatini)
-
Macedonia, which is also registered in #country_by_code as "Macedonia, The Former Yugoslav Republic Of", was renamed "North Macedonia" in 2019
https://www.un.org/en/about-us/member-states/yugoslavia -
Turkey changed its spelling to "Türkiye" in 2022
https://www.un.org/en/about-us/member-states/turkiye
This is only an issue in the English locale, as the French one has no country name and the Japanese is already up to date.
Case/spelling inconsistency:
- The countries listed as keys in "country_by_name" are all in snake case, except for "solomon Islands" and "wallis And Futuna".
- The "Virgin Islands, U.S." listed in "country" is listed as "Virgin Islands, U.s." in the country_by_code's corresponding value.
Expected behavior
I would suggest to make some changes as follows:
country names:
"Cape Verde" -> "Cabo Verde"
"Macedonia" -> "North Macedonia"
"Swaziland" -> "Eswatini"
"Turkey" -> "Türkiye"
country_by_code keys:
cape_verde -> cabo_verde
swaziland -> eswatini
macedonia_the_former_yugoslav_republic_of -> north_macedonia
solomon Islands -> solomon_islands
turkey -> türkiye
wallis And Futuna -> wallis_and_futuna
country_by_code values:
"Cape Verde" -> "Cabo Verde"
"Swaziland" -> "Eswatini"
"Virgin Islands, U.s." -> "Virgin Islands, U.S."
"Macedonia, The Former Yugoslav Republic Of" -> "North Macedonia"
"Turkey" -> "Türkiye"
I am happy to open a PR if you think this would be worth changing.
Additional context
Here's a reference for countries that have changed their names: https://en.wikipedia.org/wiki/Geographical_renaming#List_of_significant_name_changes
The ones I mentioned do not seem to have changed their country code as far as I can tell: https://en.wikipedia.org/wiki/ISO_3166-1