Fix syntax highlighting for nested directives inside define blocks #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@tendrils, Have you tested the patch? I should check one on my side as well. Usually, I convert xml to json and put to vscode. |
Author
|
I've verified that this change to the grammar works in vscode, but not anywhere else. This patch was made by backporting that change from json to xml. Existing version: |
Owner
|
Yeah, it's enough. Actually, looks cool. Give me a few days, I will double check on tests. |
Author
|
Happy to help. I've submitted this patch to upstream as well, not sure how likely they are to respond though, lol |
Owner
|
@tendrils Merged, thanks. The updated highlighting will have been pulled to VS Code during periodical grammar update there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's not a widely used feature of Make, it is valid to nest define/endef blocks within one another arbitrarily in a makefile (at least in the case of GNU Make). This syntax change fixes highlighting of such nested blocks.