Default to XDG_DATA_HOME.#141
Merged
facundoolano merged 16 commits intofacundoolano:mainfrom May 25, 2022
Merged
Conversation
facundoolano
requested changes
May 24, 2022
Owner
facundoolano
left a comment
There was a problem hiding this comment.
This sounds reasonable (ideally the data dir should be customizable by environment vars but no need to do that as part of this PR). Do you mind updating data dir references in the doc and adding an entry to the changelog?
Using XDG_DATA_HOME instead.
fix wrong path
Owner
|
the build broke btw |
Contributor
Author
Weird. It should work. The only thing I could think of is that I tested it on a test user and it gave me the same error. Only happens when |
Contributor
Author
|
I made it so if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now a directory in HOME/.rpg is used.
This clutters the HOME directory and makes the program fail if you have the home folder not writable.
Instead the files should be placed in XDG_DATA_HOME.
This will help people keep their home folders clean.
All existing people that have a HOME/.rpg folder will still have their saves.