Skip to content

Support alternate fenced header form#2470

Merged
facelessuser merged 6 commits intomainfrom
feature/superfences-alt-header
Sep 27, 2024
Merged

Support alternate fenced header form#2470
facelessuser merged 6 commits intomainfrom
feature/superfences-alt-header

Conversation

@facelessuser
Copy link
Owner

Based off of @dmadisetti's code in PR #2468

@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: docs Related to documentation. C: infrastructure Related to project infrastructure. C: source Related to source code. C: superfences Related to the superfences extension. C: tests Related to testing. labels Sep 27, 2024
Copy link

@dmadisetti dmadisetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't get back to you yesterday. Thanks! Looks like a few other changes snuck in, but LGTM. Will close out my PR


self.check_markdown(
r'''
```python {.test .class #id data-attr="test" linenums="1"}
Copy link

@dmadisetti dmadisetti Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't catch the

```python data-attr="something"
content
```

case

@facelessuser
Copy link
Owner Author

Woops, yeah, I hadn't comitted the previous commit. It's on main now, so this should only merge the new changes.

@gir-bot gir-bot removed the C: infrastructure Related to project infrastructure. label Sep 27, 2024
@facelessuser
Copy link
Owner Author

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. labels Sep 27, 2024
@facelessuser facelessuser merged commit 4b54d02 into main Sep 27, 2024
@facelessuser facelessuser deleted the feature/superfences-alt-header branch September 27, 2024 15:16
@facelessuser
Copy link
Owner Author

Release initiated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C: docs Related to documentation. C: source Related to source code. C: superfences Related to the superfences extension. C: tests Related to testing. S: approved The pull request is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants