fancylist inject class remove semicolon#2464
Conversation
|
I don't view this as a problem that needs fixing as much as a subjective user preference. |
|
Oh, I assumed it was a typo. I've never seen semicolons in HTML classes. Isn't more common not to use them? |
No, not a typo, but I honestly don't have strong feelings either way. It seemed like it was stated as a problem, but I don't think it really matters.
It wouldn't surprise me if one was somewhat more popular than others. I know people that have definite preferences for or against them at the end. I don't know what the split on preference is. I think at some point it used to be required, but I think these days most browsers are more forgiving. If you go online, you'll often see it taught to always add the I guess my point is I don't really care it's there or not, but I guess I'm not against removing it either 🤷🏻. |
I get why you have implemented that way in the <ol class="fancylists-lower-alpha;" type="a">
<li>List item</li>
</ol>With the current implementation, CSS selector should be Example: .fancylists-lower-alpha\; li::marker {
content: counter(list-item, lower-alpha) ") ";
}
.fancylists-upper-alpha\; li::marker {
content: counter(list-item, upper-alpha) ") ";
}Instead of: .fancylists-lower-alpha li::marker {
content: counter(list-item, lower-alpha) ") ";
}
.fancylists-upper-alpha li::marker {
content: counter(list-item, upper-alpha) ") ";
} |
|
Oh, a semicolon in the class?! Oh, that is definitely a typo. |
|
I completely missed that |
|
@gir-bot lgtm |
|
Sorry for the misunderstanding. I should have written a better PR text. Thanks! |
|
I should have looked over the review closer 😅 |
Removes the semicolon at the end of the injected class in
fancylists.