Skip to content

[test]: test adascale with oss#328

Merged
min-xu-ai merged 8 commits intomasterfrom
min/ada_interop
Jan 28, 2021
Merged

[test]: test adascale with oss#328
min-xu-ai merged 8 commits intomasterfrom
min/ada_interop

Conversation

@min-xu-ai
Copy link
Copy Markdown
Contributor

@min-xu-ai min-xu-ai commented Jan 26, 2021 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #302 .

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 26, 2021
anj-s
anj-s reviewed Jan 26, 2021
View reviewed changes
blefaudeux
blefaudeux reviewed Jan 26, 2021
View reviewed changes
anj-s
anj-s reviewed Jan 26, 2021
View reviewed changes
anj-s
anj-s reviewed Jan 26, 2021
View reviewed changes
@min-xu-ai
Copy link
Copy Markdown
Contributor Author

min-xu-ai commented Jan 27, 2021

Thank you @anj-s and @blefaudeux. Great suggestions. I will refactor accordingly.

@min-xu-ai min-xu-ai requested review from anj-s and blefaudeux January 28, 2021 01:21
anj-s
anj-s reviewed Jan 28, 2021
View reviewed changes
anj-s
anj-s reviewed Jan 28, 2021
View reviewed changes
anj-s
anj-s reviewed Jan 28, 2021
View reviewed changes
@anj-s
Copy link
Copy Markdown
Contributor

anj-s commented Jan 28, 2021

Thank you @min-xu-ai. The tests look really clean and a great template for the team.

@min-xu-ai
Copy link
Copy Markdown
Contributor Author

min-xu-ai commented Jan 28, 2021

Thank you @min-xu-ai. The tests look really clean and a great template for the team.

Thanks! Did you mean to approve it? :-)

blefaudeux
blefaudeux approved these changes Jan 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@blefaudeux blefaudeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great addition @min-xu-ai !

@min-xu-ai min-xu-ai merged commit fa11d33 into master Jan 28, 2021
@min-xu-ai min-xu-ai deleted the min/ada_interop branch January 28, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msbaines msbaines Awaiting requested review from msbaines

2 more reviewers

@anj-s anj-s anj-s left review comments

@blefaudeux blefaudeux blefaudeux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[test] ensure adascale works with zero

4 participants

@min-xu-ai @anj-s @blefaudeux @facebook-github-bot