feat: Add support for double to timestamp cast for Spark#12230
Closed
ArnavBalyan wants to merge 1 commit intofacebookincubator:mainfrom
Closed
feat: Add support for double to timestamp cast for Spark#12230ArnavBalyan wants to merge 1 commit intofacebookincubator:mainfrom
ArnavBalyan wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
Contributor
ArnavBalyan
commented
Jan 31, 2025
- Add support for double to timestamp cast for Spark
- Replicates the same behaviour as Spark cast for double to timestamp
Contributor
Author
|
cc @rui-mo can you please take a look |
✅ Deploy Preview for meta-velox canceled.
|
rui-mo
reviewed
Feb 12, 2025
Contributor
rui-mo
left a comment
There was a problem hiding this comment.
Hi @ArnavBalyan, thanks for your work! While this change appears to be duplicate with #12041. cc: @boneanxs
Contributor
Author
Ah did not notice the other PR, there seems to be good progress there. I'll update Gluten change (apache/gluten#8640) enable the cast once PR #12041 is closed. Let me close this, does that sound good? @rui-mo @boneanxs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.