feat(parquet): Add Int64 Timestamp in reader#11530
Closed
zuyu wants to merge 1 commit intofacebookincubator:mainfrom
zuyu:ts-int64
Closed
feat(parquet): Add Int64 Timestamp in reader#11530zuyu wants to merge 1 commit intofacebookincubator:mainfrom zuyu:ts-int64
zuyu wants to merge 1 commit intofacebookincubator:mainfrom
zuyu:ts-int64
Conversation
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
reviewed
Nov 13, 2024
Contributor
|
Could you add some unit tests? |
surnaik
suggested changes
Nov 20, 2024
|
I am assuming you're also planning to add support for Dictionary encoding and range filters, currently the range filter is always casted to INT96 range filter. |
Collaborator
rui-mo
reviewed
Dec 17, 2024
Contributor
rui-mo
left a comment
There was a problem hiding this comment.
Thanks! I added some comments.
Contributor
Author
|
@rui-mo Addressed ur comments. Could u take another look? The test failures are the same as the |
rui-mo
approved these changes
Dec 19, 2024
Contributor
rui-mo
left a comment
There was a problem hiding this comment.
Thanks! Added some nits and overall looks good to me.
Contributor
There was a problem hiding this comment.
in nano precision
nit: is other precision other than nano possible?
Contributor
Author
There was a problem hiding this comment.
No, other precisions handle separately: see #11600 (comment)
Contributor
|
@zacw7 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
This was referenced Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
w/ both plain and dictionary encoding support.