Support semi projection join type in smj#10456
Closed
JkSelf wants to merge 1 commit intofacebookincubator:mainfrom
Closed
Support semi projection join type in smj#10456JkSelf wants to merge 1 commit intofacebookincubator:mainfrom
JkSelf wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
245606e to
1e7ed27
Compare
Contributor
Author
|
@pedroerp Can you help to review this PR? Thanks for your help. |
Contributor
Author
pedroerp
reviewed
Nov 20, 2024
| isRightFlattened_ = false; | ||
| } | ||
| currentRight_ = right; | ||
| if (isRightSemiProjectJoin(joinType_) || isLeftSemiProjectJoin(joinType_)) { |
Contributor
There was a problem hiding this comment.
nit: maybe add a quick comment here that for semi project joins we need to produce the match output column
| } | ||
| currentRight_ = right; | ||
| if (isRightSemiProjectJoin(joinType_) || isLeftSemiProjectJoin(joinType_)) { | ||
| localColumns[outputType_->size() - 1] = BaseVector::create( |
Contributor
There was a problem hiding this comment.
nit: could we do localColumns.back() = ... instead?
| const auto& filterRows = joinTracker_->matchingRows(numRows); | ||
|
|
||
| auto lastChildren = output->children().back(); | ||
| auto flatMatch = lastChildren->as<FlatVector<bool>>(); |
Contributor
There was a problem hiding this comment.
can't we here do a simple copy of the underlying buffers instead of an explicit for loop?
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return each row from the left or right side with a boolean flag indicating whether there exists a match on the right or left side. If there is a filter, the boolean value will be set based on the result of the filter in the applyFilter method. If there is no filter, the filterOutputForSemiProject is added to set the boolean value based on the records in joinTracker's matchingRows.